You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by martin-g <gi...@git.apache.org> on 2017/09/04 18:43:33 UTC

[GitHub] wicket pull request #232: Ajax inline enclosure fix

Github user martin-g commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/232#discussion_r136861843
  
    --- Diff: wicket-core/src/test/java/org/apache/wicket/markup/renderStrategy/ChildFirstHeaderRenderStrategyTest.java ---
    @@ -51,6 +57,39 @@ public void test2() throws Exception
     	}
     
     	/**
    +	 * Tests that when a controller of an enclosure is added to the ajax target, its header
    +	 * contributions reach the response
    +	 *
    +	 * WICKET-6459
    +	 *
    +	 */
    +	@Test
    +	public void testAjaxAndEnclosures() throws Exception
    +	{
    +
    +		tester.startPage(SimplePage3.class);
    --- End diff --
    
    Let's rename the page name to `InlineEnclosureAjaxRenderPage`.
    `SimplePage`s are legacy, but for new stuff we should try better! :-)


---