You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/17 07:29:21 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3085: cxd56_cpu1signal: Fix an issue that gnss does not work

xiaoxiang781216 commented on a change in pull request #3085:
URL: https://github.com/apache/incubator-nuttx/pull/3085#discussion_r595768907



##########
File path: arch/arm/src/cxd56xx/cxd56_cpu1signal.c
##########
@@ -194,21 +192,18 @@ int cxd56_cpu1siginit(uint8_t sigtype, FAR void *data)
       goto err0;
     }
 
-  pthread_attr_init(&tattr);
-  tattr.stacksize      = CONFIG_CXD56CPU1_WORKER_STACKSIZE;
-  param.sched_priority = CONFIG_CXD56CPU1_WORKER_THREAD_PRIORITY;
-  pthread_attr_setschedparam(&tattr, &param);
+  pid = task_create("gnss_receiver", CONFIG_CXD56CPU1_WORKER_THREAD_PRIORITY,

Review comment:
       task_create is for userspace application, please replace with kthread_create instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org