You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by keybod <gi...@git.apache.org> on 2015/11/25 09:28:38 UTC
[GitHub] tajo pull request: TAJO-1985: Supporting Metric report via JMX.
GitHub user keybod opened a pull request:
https://github.com/apache/tajo/pull/879
TAJO-1985: Supporting Metric report via JMX.
I added a JMX metric reporter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keybod/tajo TAJO-1985
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #879
----
commit e07a9639f5cdd9483765b49c350e6602c4c87d8c
Author: Yongjun Park <th...@gmail.com>
Date: 2015-11-25T08:23:59Z
TAJO-1985: Add reporting metrics via JMX.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1985: Supporting Metric report via JMX.
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/879#issuecomment-159547563
Travis failure is not related this PR
Could you trigger the travis CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1985: Supporting Metric report via JMX.
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/879#issuecomment-160032933
+1 LGTM!
Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1985: Supporting Metric report via JMX.
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/879#discussion_r46014251
--- Diff: tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java ---
@@ -113,6 +117,9 @@ public void start() {
final String jvmMetricsName = metricsGroupName + "-JVM";
setMetricsReporter(jvmMetricsName);
+ jmxReporter = JmxReporter.forRegistry(metricRegistry).inDomain("Tajo")
--- End diff --
This line should move into the ’if(!inited) {}’
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1985: Supporting Metric report via JMX.
Posted by keybod <gi...@git.apache.org>.
Github user keybod commented on the pull request:
https://github.com/apache/tajo/pull/879#issuecomment-160032738
Thank you for reviewing!
I have applied it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1985: Supporting Metric report via JMX.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---