You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 23:21:21 UTC
[GitHub] [spark] zr-msft opened a new pull request #35561: [Docs] fixed typo in closing tags causing rendering issues in running-on-kubernetes.md
zr-msft opened a new pull request #35561:
URL: https://github.com/apache/spark/pull/35561
*This contribution is my original work and I license the work to the project under the project’s open source license.*
### What changes were proposed in this pull request?
Several `<code>` elements in `running-on-kubernetes.md` had typos in their closing tags, causing rendering issues on the HTML site. Example of rendering issue:
https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#spark-properties
This PR fixes those typos and resolves the rendering issue.
### Why are the changes needed?
The typo fixes allows the HTML site to render the article correctly.
### Does this PR introduce _any_ user-facing change?
Yes, currently the site shows several headers and closing tags as plain text:
https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#spark-properties
This PR allows those headers to be correctly rendered and no longer shows the table's closing tags.
### How was this patch tested?
No tests were added. I did a local build of the site per the instructions and confirmed the HTML renders correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35561: [MINOR][DOCS] Fixed closing tags in running-on-kubernetes.md
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35561:
URL: https://github.com/apache/spark/pull/35561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35561: [MINOR][DOCS] Fixed closing tags in running-on-kubernetes.md
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35561:
URL: https://github.com/apache/spark/pull/35561#issuecomment-1043663966
There is a conflict on branch-3.2. You can make a backporting PR against `branch-3.2` if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org