You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2024/07/23 12:12:26 UTC

[PR] [ISSUE #8262] Add more test coverage for ClientRemotingProcessor [rocketmq]

yx9o opened a new pull request, #8433:
URL: https://github.com/apache/rocketmq/pull/8433

   
   For #8262 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8262] Add more test coverage for ClientRemotingProcessor [rocketmq]

Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing commented on PR #8433:
URL: https://github.com/apache/rocketmq/pull/8433#issuecomment-2246732265

   it‘s better to create a new issue for this PR, 
   ![image](https://github.com/user-attachments/assets/9eedd22a-2150-4085-86d2-e4f9c8e772cc)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8262] Add more test coverage for ClientRemotingProcessor [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8433:
URL: https://github.com/apache/rocketmq/pull/8433#issuecomment-2245143816

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8433?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 45.62%. Comparing base [(`6fb455a`)](https://app.codecov.io/gh/apache/rocketmq/commit/6fb455a1d4dc7416c81ad447fbfe4f9429765609?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`09f76b9`)](https://app.codecov.io/gh/apache/rocketmq/commit/09f76b949ff8020bf6a01fbaf9a53858a6acdda9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #8433      +/-   ##
   =============================================
   + Coverage      45.54%   45.62%   +0.08%     
   - Complexity     11031    11036       +5     
   =============================================
     Files           1274     1274              
     Lines          88997    88997              
     Branches       11440    11440              
   =============================================
   + Hits           40532    40605      +73     
   + Misses         43427    43326     -101     
   - Partials        5038     5066      +28     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8433?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8262] Add more test coverage for ClientRemotingProcessor [rocketmq]

Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing commented on PR #8433:
URL: https://github.com/apache/rocketmq/pull/8433#issuecomment-2246730756

   link #8262 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8437] Add more test coverage for ClientRemotingProcessor [rocketmq]

Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu merged PR #8433:
URL: https://github.com/apache/rocketmq/pull/8433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org