You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/09 07:31:31 UTC
[GitHub] [ignite] Berkof opened a new pull request #9392: IGNITE-15289 Global statistics collection
Berkof opened a new pull request #9392:
URL: https://github.com/apache/ignite/pull/9392
Add new IgniteGlobalStatisticsManager to gather global statistics from the local ones. They choose some statistics master node for each table and request it when they need global statistics (collect by request only).
Global statistics will be cached until its configuration changed. Statistics master node in its turn will send requests to get appropriate (fresh config enough with specified topology version) local statistics from each node and aggregate it to the global one. Then it'll respond to each global statistics request. If topology change occurs during global statistics aggregation - all progress should be dropped and aggregation should be restarted automatically.
To support such a mechanism two additional messages were introduced: StatisticsRequest and StatisticsResponse. To track which global statistics are available on a particular node StatisticsGlobalData view was added (like StatisticsLocalData, but contains global characteristics of the tables).
IgniteTableImpl now relies on global statistics instead of local ones so most tests were switched from local to global statistics checks. Anyway - global statistics require a local one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708267762
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
Review comment:
the first letter should be capitalised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708372423
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsHelper.java
##########
@@ -67,6 +72,61 @@ public IgniteStatisticsHelper(
this.log = logSupplier.apply(IgniteStatisticsHelper.class);
}
+ /**
+ * Get cache group context by specified statistics key.
+ *
+ * @param key Statistics key to get context by.
+ * @return Cache group context for the given key.
+ * @throws IgniteCheckedException If unable to find table by specified key.
+ */
+ public CacheGroupContext getGroupContext(StatisticsKey key) throws IgniteCheckedException {
Review comment:
we don't use get-/set- prefixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744785041
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.statMgr = statMgr;
+ //this.statProc = statProc;
Review comment:
commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r741864717
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
Review comment:
Done
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/BusyExecutor.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.internal.util.GridBusyLock;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Executor with busy run support.
+ * Can run any tasks while active and safelly wait untill they stopped.
+ */
+public class BusyExecutor {
Review comment:
How we can wrap each runnable with a busy lock? We need one lock to allow graceful shutdown and that lock is located in BusyExecutor.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
+ return;
+
+ List<StatisticsAddressedRequest> inReqs[] = new List[1];
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+ inReqs[0] = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()))
+ inReqs[0].add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs[0] == null)
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs[0]) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cache entry original timestamp. */
+ private final long cachedAt;
+
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ cachedAt = System.currentTimeMillis();
+ this.obj = obj;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param cachedAt Cache original timestamp.
+ * @param obj Object to cache.
+ */
+ public CacheEntry(long cachedAt, T obj) {
+ this.cachedAt = cachedAt;
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cache entry original timestamp.
+ */
+ public long cachedAt() {
+ return cachedAt;
Review comment:
Removed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
Review comment:
Done
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/BusyExecutor.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.internal.util.GridBusyLock;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Executor with busy run support.
+ * Can run any tasks while active and safelly wait untill they stopped.
+ */
+public class BusyExecutor {
Review comment:
How we can wrap each runnable with a busy lock? We need one lock to allow graceful shutdown and that lock is located in BusyExecutor.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
+ return;
+
+ List<StatisticsAddressedRequest> inReqs[] = new List[1];
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+ inReqs[0] = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()))
+ inReqs[0].add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs[0] == null)
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs[0]) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cache entry original timestamp. */
+ private final long cachedAt;
+
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ cachedAt = System.currentTimeMillis();
+ this.obj = obj;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param cachedAt Cache original timestamp.
+ * @param obj Object to cache.
+ */
+ public CacheEntry(long cachedAt, T obj) {
+ this.cachedAt = cachedAt;
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cache entry original timestamp.
+ */
+ public long cachedAt() {
+ return cachedAt;
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745549211
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
Review comment:
Removed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
Review comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745548832
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.statMgr = statMgr;
+ //this.statProc = statProc;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ statMgr.subscribeToLocalStatistics(nls -> onLocalStatisticsAggregated(nls.get1(), nls.get2(), nls.get3()));
+ statMgr.subscribeToStatisticsConfig(this::onConfigChanged);
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /**
+ * Start operations.
+ * Shouldn't be called twice.
+ */
+ public synchronized void start() {
+ if (started) {
+ if (log.isDebugEnabled())
+ log.debug("IgniteGlobalStatisticsManager already started.");
+
+ return;
+ }
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ started = true;
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /**
+ * Stop operations.
+ * Shouldn't be called twice.
+ */
+ public synchronized void stop() {
+ if (!started) {
+ if (log.isDebugEnabled())
+ log.debug("IgniteGlobalStatisticsManager already stopped.");
+
+ return;
+ }
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ started = false;
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but there is cache record with
+ * empty object - no additional collection will be started.
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = statMgr.statisticConfiguration().config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId, statCfg);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ log.warning("Unable to process statistics message: " + e.getMessage(), e);
+ }
+ });
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ ObjectStatisticsImpl objectStatistics = statMgr.getLocalStatistics(key, req.topVer());
+
+ if (StatisticsUtils.compareVersions(objectStatistics, req.versions()) == 0)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ objectStatistics = statMgr.getLocalStatistics(key, req.topVer());
+
+ if (StatisticsUtils.compareVersions(objectStatistics, req.versions()) == 0) {
+ StatisticsAddressedRequest removed = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ ObjectStatisticsImpl objStatistics = getGlobalStatistics(key, req.versions());
+
+ if (objStatistics == null) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+ globalStatistics.computeIfAbsent(key, k -> new CacheEntry<>(null));
+
+ if (!hasCurrentCollection(key, req.versions())) {
+ StatisticsObjectConfiguration objCfg = statMgr.statisticConfiguration().config(key);
+
+ if (StatisticsUtils.compareVersions(objCfg, req.versions()) >= 0)
+ gatherGlobalStatistics(objCfg);
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Wait for statistics configuration to process global statistics request " +
+ req.reqId());
+ }
+ }
+ }
+
+ objStatistics = getGlobalStatistics(key, req.versions());
+
+ if (objStatistics != null) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objStatistics);
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objStatistics);
+ }
+
+ /**
+ * Check if there are already started current collection with specified parameters.
+ *
+ * @param key Statistics key.
+ * @param versions Reuqired versions.
+ * @return {@code true} if there are already current collection with specifie parameters, {@code false} - otherwise.
+ */
+ private boolean hasCurrentCollection(StatisticsKey key, Map<String, Long> versions) {
+ StatisticsGatheringContext ctx = curCollections.get(key);
+
+ if (ctx == null)
+ return false;
+
+ return StatisticsUtils.compareVersions(ctx.configuration(), versions) == 0;
+ }
+
+ /**
+ * Get apptopriate global statistics from cache.
+ *
+ * @param key Statistics key.
+ * @param versions Required versions.
+ * @return Global statistics or {@code null} if there are no such global statistics.
+ */
+ private ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key, Map<String, Long> versions) {
+ CacheEntry<ObjectStatisticsImpl> objStatEntry = globalStatistics.get(key);
+
+ if (objStatEntry == null || StatisticsUtils.compareVersions(objStatEntry.object(), versions) != 0)
+ return null;
+
+ return objStatEntry.object();
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all outbound activity by specified key, inbound may be suspended due to lack of
+ * requested configuration.
+ * 2) Remove all inbound activity by changed key if reqiest col cfg versions lower than configuration col cfg versions.
+ * 3.1) If there are no live column's config - remove cached global statistics.
+ * 3.2) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ // Current config newer than income request - request should be invalidated.
+ v.removeIf(req -> StatisticsUtils.compareVersions(cfg, req.req().versions()) > 0);
+
+ return (v.isEmpty()) ? null : v;
+ });
+
+ inGloblaRequests.computeIfPresent(key, (k, v) -> {
+ v.removeIf(req -> StatisticsUtils.compareVersions(cfg, req.req().versions()) > 0);
+
+ return (v.isEmpty()) ? null : v;
+ });
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null) {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics recollection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear global statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = statMgr.statisticConfiguration().config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return UUID of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ List<StatisticsAddressedRequest> inReqs = new ArrayList<>();
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()) &&
+ StatisticsUtils.compareVersions(statistics, req.req().versions()) == 0)
+ inReqs.add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs.isEmpty())
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cached object.
+ */
+ public T object() {
+ return obj;
+ }
+ }
+
+ /** Context of global statistics gathering. */
+ private static class StatisticsGatheringContext {
+ /** Number of remaining requests. */
+ private int remainingResponses;
+
+ /** Requests id. */
+ private final UUID reqId;
+
+ /** Local object statistics from responses. */
+ private final Collection<ObjectStatisticsImpl> responses = new ArrayList<>();
+
+ /** Configuration, used to collect statistics. */
+ private final StatisticsObjectConfiguration cfg;
+
+ /**
+ * Constructor.
+ *
+ * @param responseCont Expectiong response count.
+ * @param reqId Requests id.
+ * @param cfg Configuration, used to collect statistics.
+ */
+ public StatisticsGatheringContext(int responseCont, UUID reqId, StatisticsObjectConfiguration cfg) {
+ remainingResponses = responseCont;
+ this.reqId = reqId;
+ this.cfg = cfg;
+ }
+
+ /**
+ * Register response.
+ *
+ * @param data Object statistics from response.
+ * @return {@code true} if all respones collected, {@code false} otherwise.
+ */
+ public synchronized boolean registerResponse(ObjectStatisticsImpl data) {
Review comment:
Just to use simple array list collections inside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745553029
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsConfigurationTest.java
##########
@@ -231,7 +231,9 @@ public void checkClientNode() throws Exception {
IgniteEx client = startClientGrid("cli");
- collectStatistics(SMALL_TARGET);
+ Thread.sleep(1000);
Review comment:
Replaced with awaitPartitionMapExchange with slightly bigger collection timeout to make tests more stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#issuecomment-966097211
please fix checkstyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745549599
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.statMgr = statMgr;
+ //this.statProc = statProc;
Review comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r716432881
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
Review comment:
You are right, this is quite obvious. Then I don't understand why you did this before commit `9785f98`. Please add appropriate guard to the component to avoid similar situations in the future.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
+ return;
+
+ List<StatisticsAddressedRequest> inReqs[] = new List[1];
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+ inReqs[0] = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()))
+ inReqs[0].add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs[0] == null)
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs[0]) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cache entry original timestamp. */
+ private final long cachedAt;
+
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ cachedAt = System.currentTimeMillis();
+ this.obj = obj;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param cachedAt Cache original timestamp.
+ * @param obj Object to cache.
+ */
+ public CacheEntry(long cachedAt, T obj) {
+ this.cachedAt = cachedAt;
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cache entry original timestamp.
+ */
+ public long cachedAt() {
+ return cachedAt;
Review comment:
I think there should be no unused code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708934205
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/AbstractPlannerTest.java
##########
@@ -376,12 +376,12 @@ protected void checkSplitAndSerialization(IgniteRel rel, IgniteSchema publicSche
clearTraits(deserialized);
if (!expected.deepEquals(deserialized))
- assertTrue(
- "Invalid serialization / deserialization.\n" +
- "Expected:\n" + RelOptUtil.toString(expected) +
- "Deserialized:\n" + RelOptUtil.toString(deserialized),
- expected.deepEquals(deserialized)
- );
+ assertTrue(
Review comment:
DONE
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsViewsPersistenceTest.java
##########
@@ -29,13 +27,6 @@
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
- cfg.setConsistentId(igniteInstanceName);
-
- DataStorageConfiguration memCfg = new DataStorageConfiguration()
- .setDefaultDataRegionConfiguration(new DataRegionConfiguration().setPersistenceEnabled(true));
-
- cfg.setDataStorageConfiguration(memCfg);
-
- return cfg;
+ return addPersistence(cfg, igniteInstanceName);
Review comment:
Fixed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
Review comment:
Removed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
Review comment:
Removed
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
Review comment:
Add few checks to avoid it.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
+ return;
+
+ List<StatisticsAddressedRequest> inReqs[] = new List[1];
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+ inReqs[0] = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()))
+ inReqs[0].add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs[0] == null)
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs[0]) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cache entry original timestamp. */
+ private final long cachedAt;
+
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ cachedAt = System.currentTimeMillis();
+ this.obj = obj;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param cachedAt Cache original timestamp.
+ * @param obj Object to cache.
+ */
+ public CacheEntry(long cachedAt, T obj) {
+ this.cachedAt = cachedAt;
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cache entry original timestamp.
+ */
+ public long cachedAt() {
+ return cachedAt;
Review comment:
I planned to add TTL here or we can show it in statistics view. What do you think about it? Remove or add one more column or left here for TTL?
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsConfigurationTest.java
##########
@@ -270,16 +270,18 @@ public void dropUpdate() throws Exception {
createSmallTable(null);
- collectStatistics(SMALL_TARGET);
+ collectStatistics(StatisticsType.GLOBAL, SMALL_TARGET);
waitForStats(SCHEMA, "SMALL", TIMEOUT, checkTotalRows, checkColumStats);
+ System.out.println("Drop SMALL.A statistics");
Review comment:
Removed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
Review comment:
Finished. "but there is cache record with empty object - no additional collection will be started."
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
Review comment:
It's quite obvious that you shouldn't start the component twice, but I add it in javadoc.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
Review comment:
Because statistics collection problem isn't so important to cluster operations. Changed to warn.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
Review comment:
Done
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/PSUBasicValueDistributionTableStatisticsUsageTest.java
##########
@@ -93,7 +93,7 @@
sql("CREATE INDEX empty_distribution_no_stat_col_a ON empty_distribution_no_stat(col_a)");
- collectStatistics("digital_distribution", "empty_distribution");
+ collectStatistics(StatisticsType.GLOBAL, "digital_distribution", "empty_distribution");
Review comment:
It'll be confusing with the same name due to new type of statistics.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsManagerImpl.java
##########
@@ -278,6 +306,9 @@ public IgniteStatisticsRepository statisticsRepository() {
if (!unfinishedTasks.isEmpty())
log.warning(String.format("%d statistics configuration change handler cancelled.", unfinishedTasks.size()));
}
+
+ if (log.isDebugEnabled())
+ log.debug("Statistics manager started.");
Review comment:
Message fixed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
Review comment:
Definitely no, but we have dedicated TOPIC_STATISTICS so there shouldn't be any unsupported messages here.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsHelper.java
##########
@@ -67,6 +72,61 @@ public IgniteStatisticsHelper(
this.log = logSupplier.apply(IgniteStatisticsHelper.class);
}
+ /**
+ * Get cache group context by specified statistics key.
+ *
+ * @param key Statistics key to get context by.
+ * @return Cache group context for the given key.
+ * @throws IgniteCheckedException If unable to find table by specified key.
+ */
+ public CacheGroupContext getGroupContext(StatisticsKey key) throws IgniteCheckedException {
Review comment:
It's not just getter, but renamed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsManagerImpl.java
##########
@@ -158,6 +162,22 @@ else if (db == null)
ctx::log
);
+ globalStatsMgr = new IgniteGlobalStatisticsManager(
+ statCfgMgr,
+ ctx.systemView(),
+ statsRepos,
+ gatherer,
+ mgmtPool,
+ ctx.discovery(),
+ ctx.state(),
+ ctx.cache().context().exchange(),
+ helper,
+ ctx.io(),
+ ctx::log);
+
+ statsRepos.setGlobalStatMgr(globalStatsMgr);
Review comment:
StatRepo uses GlobalStatMgr to notify about statistics aggregation finished event.
StatCfgMgr uses GlobalStatMgr to clear global statistics after configuration changes.
GlobalStatMgr uses both StatRepo and StatCfgMgr to get local statistics and statistics configuration.
The only thing I can do is to pass IgniteStatisticsManager to GlobalStatMgr and pass requests through it. Is it better now?
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
Review comment:
Fixed
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
Review comment:
No, if removed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708255822
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
+ return;
+
+ List<StatisticsAddressedRequest> inReqs[] = new List[1];
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+ inReqs[0] = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()))
+ inReqs[0].add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs[0] == null)
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs[0]) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cache entry original timestamp. */
+ private final long cachedAt;
+
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ cachedAt = System.currentTimeMillis();
+ this.obj = obj;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param cachedAt Cache original timestamp.
+ * @param obj Object to cache.
+ */
+ public CacheEntry(long cachedAt, T obj) {
+ this.cachedAt = cachedAt;
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cache entry original timestamp.
+ */
+ public long cachedAt() {
+ return cachedAt;
Review comment:
looks like `cachedAt` is not used anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r736277549
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/config/StatisticsObjectConfiguration.java
##########
@@ -243,6 +242,37 @@ public byte maxPartitionObsolescencePercent() {
return S.toString(StatisticsObjectConfiguration.class, this);
}
+ /**
+ * Compare only configuration from the same branch. I.e. can't correctly compare
+ * Cfg(A=v1,B=v3) vs Cfg(A=v2,B=v1)
+ * Cfg(A=v1,B=v3) vs Cfg(A=v1m C=v2)
Review comment:
```suggestion
* Cfg(A=v1,B=v3) vs Cfg(A=v1, C=v2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744706635
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsRepository.java
##########
@@ -320,4 +347,51 @@ public void saveObsolescenceInfo(StatisticsKey key) {
}
});
}
+
+ /**
+ * Subscribe to all local statistics changes.
+ *
+ * @param subscriber Local statitics subscriber.
+ */
+ public void subscribeToLocalStatistics(
+ Consumer<GridTuple3<StatisticsKey, ObjectStatisticsImpl, AffinityTopologyVersion>> subscriber
Review comment:
let's introduce class with meaningful name instead of GridTuple3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744798367
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.statMgr = statMgr;
+ //this.statProc = statProc;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ statMgr.subscribeToLocalStatistics(nls -> onLocalStatisticsAggregated(nls.get1(), nls.get2(), nls.get3()));
+ statMgr.subscribeToStatisticsConfig(this::onConfigChanged);
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /**
+ * Start operations.
+ * Shouldn't be called twice.
+ */
+ public synchronized void start() {
+ if (started) {
+ if (log.isDebugEnabled())
+ log.debug("IgniteGlobalStatisticsManager already started.");
+
+ return;
+ }
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
Review comment:
why do you clear this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745520408
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/StatisticsUtils.java
##########
@@ -172,4 +174,61 @@ public static StatisticsTarget statisticsTarget(StatisticsKeyMessage msg) {
String[] cols = (msg.colNames() == null) ? null : msg.colNames().toArray(new String[0]);
return new StatisticsTarget(msg.schema(), msg.obj(), cols);
}
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ * It means that specified statistics contains all columns with at least versions
+ * from specified map.
+ *
+ * @param stat Statistics to check. Can be {@code null}.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
Review comment:
Fixed.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
Review comment:
Removed
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsConfigurationTest.java
##########
@@ -231,7 +231,9 @@ public void checkClientNode() throws Exception {
IgniteEx client = startClientGrid("cli");
- collectStatistics(SMALL_TARGET);
+ Thread.sleep(1000);
Review comment:
Not really, replaced with awaitPME. And I increase TIMEOUT to make the tests mode stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r706107265
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsViewsInMemoryTest.java
##########
@@ -29,13 +27,6 @@
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
- cfg.setConsistentId(igniteInstanceName);
-
- DataStorageConfiguration memCfg = new DataStorageConfiguration()
- .setDefaultDataRegionConfiguration(new DataRegionConfiguration().setPersistenceEnabled(false));
-
- cfg.setDataStorageConfiguration(memCfg);
-
- return cfg;
+ return addImMemory(cfg, igniteInstanceName);
Review comment:
```suggestion
return addInMemoryRegion(cfg, igniteInstanceName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744817469
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsConfigurationTest.java
##########
@@ -231,7 +231,9 @@ public void checkClientNode() throws Exception {
IgniteEx client = startClientGrid("cli");
- collectStatistics(SMALL_TARGET);
+ Thread.sleep(1000);
Review comment:
is this `Thread.sleep` necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744649881
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/StatisticsUtils.java
##########
@@ -172,4 +174,61 @@ public static StatisticsTarget statisticsTarget(StatisticsKeyMessage msg) {
String[] cols = (msg.colNames() == null) ? null : msg.colNames().toArray(new String[0]);
return new StatisticsTarget(msg.schema(), msg.obj(), cols);
}
+
+ /**
+ * Test if specified statistics is fit to all required versions.
Review comment:
```suggestion
* Test if specified statistics are fit to all required versions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744667284
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/StatisticsUtils.java
##########
@@ -172,4 +174,61 @@ public static StatisticsTarget statisticsTarget(StatisticsKeyMessage msg) {
String[] cols = (msg.colNames() == null) ? null : msg.colNames().toArray(new String[0]);
return new StatisticsTarget(msg.schema(), msg.obj(), cols);
}
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ * It means that specified statistics contains all columns with at least versions
+ * from specified map.
+ *
+ * @param stat Statistics to check. Can be {@code null}.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
Review comment:
actually the method returns integer value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744689871
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/StatisticsUtils.java
##########
@@ -172,4 +174,61 @@ public static StatisticsTarget statisticsTarget(StatisticsKeyMessage msg) {
String[] cols = (msg.colNames() == null) ? null : msg.colNames().toArray(new String[0]);
return new StatisticsTarget(msg.schema(), msg.obj(), cols);
}
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ * It means that specified statistics contains all columns with at least versions
+ * from specified map.
+ *
+ * @param stat Statistics to check. Can be {@code null}.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ public static int compareVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return -1;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
Review comment:
from javadoc: `specified statistics contains all columns with at least versions from specified map`, but in fact the method returns as soon as the very first non equal version have found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r741864717
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
Review comment:
Done
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/BusyExecutor.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.internal.util.GridBusyLock;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Executor with busy run support.
+ * Can run any tasks while active and safelly wait untill they stopped.
+ */
+public class BusyExecutor {
Review comment:
How we can wrap each runnable with a busy lock? We need one lock to allow graceful shutdown and that lock is located in BusyExecutor.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
+ return;
+
+ List<StatisticsAddressedRequest> inReqs[] = new List[1];
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+ inReqs[0] = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()))
+ inReqs[0].add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs[0] == null)
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs[0]) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cache entry original timestamp. */
+ private final long cachedAt;
+
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ cachedAt = System.currentTimeMillis();
+ this.obj = obj;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param cachedAt Cache original timestamp.
+ * @param obj Object to cache.
+ */
+ public CacheEntry(long cachedAt, T obj) {
+ this.cachedAt = cachedAt;
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cache entry original timestamp.
+ */
+ public long cachedAt() {
+ return cachedAt;
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708126867
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
Review comment:
Currently it's unclear why `start` and `stop` operations are to made mutual exclusive. It would be great to describe this in javadoc.
This component doesn't have internal state, thus sequential call to `start` will cause a registration of two similar listeners.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
Review comment:
but what?
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
Review comment:
why INFO level is used here?
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
Review comment:
empty method
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
Review comment:
multiple invocation of this method will trigger multiple collection of global statistics
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/PSUBasicValueDistributionTableStatisticsUsageTest.java
##########
@@ -93,7 +93,7 @@
sql("CREATE INDEX empty_distribution_no_stat_col_a ON empty_distribution_no_stat(col_a)");
- collectStatistics("digital_distribution", "empty_distribution");
+ collectStatistics(StatisticsType.GLOBAL, "digital_distribution", "empty_distribution");
Review comment:
please keep the method with an old signature to avoid dozen of similar changes
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsConfigurationTest.java
##########
@@ -270,16 +270,18 @@ public void dropUpdate() throws Exception {
createSmallTable(null);
- collectStatistics(SMALL_TARGET);
+ collectStatistics(StatisticsType.GLOBAL, SMALL_TARGET);
waitForStats(SCHEMA, "SMALL", TIMEOUT, checkTotalRows, checkColumStats);
+ System.out.println("Drop SMALL.A statistics");
Review comment:
sout
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/AbstractPlannerTest.java
##########
@@ -376,12 +376,12 @@ protected void checkSplitAndSerialization(IgniteRel rel, IgniteSchema publicSche
clearTraits(deserialized);
if (!expected.deepEquals(deserialized))
- assertTrue(
- "Invalid serialization / deserialization.\n" +
- "Expected:\n" + RelOptUtil.toString(expected) +
- "Deserialized:\n" + RelOptUtil.toString(deserialized),
- expected.deepEquals(deserialized)
- );
+ assertTrue(
Review comment:
please wrap it with curly braces
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
Review comment:
Looks like topVer is never read
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
Review comment:
do we really need to spawn a task for unsupported messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708270064
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
Review comment:
blobal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708349639
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
Review comment:
is it possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744755041
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.statMgr = statMgr;
+ //this.statProc = statProc;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ statMgr.subscribeToLocalStatistics(nls -> onLocalStatisticsAggregated(nls.get1(), nls.get2(), nls.get3()));
+ statMgr.subscribeToStatisticsConfig(this::onConfigChanged);
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /**
+ * Start operations.
+ * Shouldn't be called twice.
+ */
+ public synchronized void start() {
+ if (started) {
+ if (log.isDebugEnabled())
+ log.debug("IgniteGlobalStatisticsManager already started.");
+
+ return;
+ }
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ started = true;
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /**
+ * Stop operations.
+ * Shouldn't be called twice.
+ */
+ public synchronized void stop() {
+ if (!started) {
+ if (log.isDebugEnabled())
+ log.debug("IgniteGlobalStatisticsManager already stopped.");
+
+ return;
+ }
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ started = false;
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but there is cache record with
+ * empty object - no additional collection will be started.
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = statMgr.statisticConfiguration().config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId, statCfg);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ log.warning("Unable to process statistics message: " + e.getMessage(), e);
+ }
+ });
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ ObjectStatisticsImpl objectStatistics = statMgr.getLocalStatistics(key, req.topVer());
+
+ if (StatisticsUtils.compareVersions(objectStatistics, req.versions()) == 0)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ objectStatistics = statMgr.getLocalStatistics(key, req.topVer());
+
+ if (StatisticsUtils.compareVersions(objectStatistics, req.versions()) == 0) {
+ StatisticsAddressedRequest removed = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ ObjectStatisticsImpl objStatistics = getGlobalStatistics(key, req.versions());
+
+ if (objStatistics == null) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+ globalStatistics.computeIfAbsent(key, k -> new CacheEntry<>(null));
+
+ if (!hasCurrentCollection(key, req.versions())) {
+ StatisticsObjectConfiguration objCfg = statMgr.statisticConfiguration().config(key);
+
+ if (StatisticsUtils.compareVersions(objCfg, req.versions()) >= 0)
+ gatherGlobalStatistics(objCfg);
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Wait for statistics configuration to process global statistics request " +
+ req.reqId());
+ }
+ }
+ }
+
+ objStatistics = getGlobalStatistics(key, req.versions());
+
+ if (objStatistics != null) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objStatistics);
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objStatistics);
+ }
+
+ /**
+ * Check if there are already started current collection with specified parameters.
+ *
+ * @param key Statistics key.
+ * @param versions Reuqired versions.
+ * @return {@code true} if there are already current collection with specifie parameters, {@code false} - otherwise.
+ */
+ private boolean hasCurrentCollection(StatisticsKey key, Map<String, Long> versions) {
+ StatisticsGatheringContext ctx = curCollections.get(key);
+
+ if (ctx == null)
+ return false;
+
+ return StatisticsUtils.compareVersions(ctx.configuration(), versions) == 0;
+ }
+
+ /**
+ * Get apptopriate global statistics from cache.
+ *
+ * @param key Statistics key.
+ * @param versions Required versions.
+ * @return Global statistics or {@code null} if there are no such global statistics.
+ */
+ private ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key, Map<String, Long> versions) {
+ CacheEntry<ObjectStatisticsImpl> objStatEntry = globalStatistics.get(key);
+
+ if (objStatEntry == null || StatisticsUtils.compareVersions(objStatEntry.object(), versions) != 0)
+ return null;
+
+ return objStatEntry.object();
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all outbound activity by specified key, inbound may be suspended due to lack of
+ * requested configuration.
+ * 2) Remove all inbound activity by changed key if reqiest col cfg versions lower than configuration col cfg versions.
+ * 3.1) If there are no live column's config - remove cached global statistics.
+ * 3.2) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ // Current config newer than income request - request should be invalidated.
+ v.removeIf(req -> StatisticsUtils.compareVersions(cfg, req.req().versions()) > 0);
+
+ return (v.isEmpty()) ? null : v;
+ });
+
+ inGloblaRequests.computeIfPresent(key, (k, v) -> {
+ v.removeIf(req -> StatisticsUtils.compareVersions(cfg, req.req().versions()) > 0);
+
+ return (v.isEmpty()) ? null : v;
+ });
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null) {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics recollection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear global statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = statMgr.statisticConfiguration().config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return UUID of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ List<StatisticsAddressedRequest> inReqs = new ArrayList<>();
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()) &&
+ StatisticsUtils.compareVersions(statistics, req.req().versions()) == 0)
+ inReqs.add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs.isEmpty())
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cached object.
+ */
+ public T object() {
+ return obj;
+ }
+ }
+
+ /** Context of global statistics gathering. */
+ private static class StatisticsGatheringContext {
+ /** Number of remaining requests. */
+ private int remainingResponses;
+
+ /** Requests id. */
+ private final UUID reqId;
+
+ /** Local object statistics from responses. */
+ private final Collection<ObjectStatisticsImpl> responses = new ArrayList<>();
+
+ /** Configuration, used to collect statistics. */
+ private final StatisticsObjectConfiguration cfg;
+
+ /**
+ * Constructor.
+ *
+ * @param responseCont Expectiong response count.
+ * @param reqId Requests id.
+ * @param cfg Configuration, used to collect statistics.
+ */
+ public StatisticsGatheringContext(int responseCont, UUID reqId, StatisticsObjectConfiguration cfg) {
+ remainingResponses = responseCont;
+ this.reqId = reqId;
+ this.cfg = cfg;
+ }
+
+ /**
+ * Register response.
+ *
+ * @param data Object statistics from response.
+ * @return {@code true} if all respones collected, {@code false} otherwise.
+ */
+ public synchronized boolean registerResponse(ObjectStatisticsImpl data) {
Review comment:
why do you need this method sync?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744784752
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
Review comment:
commented code
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
Review comment:
commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708243939
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsManagerImpl.java
##########
@@ -278,6 +306,9 @@ public IgniteStatisticsRepository statisticsRepository() {
if (!unfinishedTasks.isEmpty())
log.warning(String.format("%d statistics configuration change handler cancelled.", unfinishedTasks.size()));
}
+
+ if (log.isDebugEnabled())
+ log.debug("Statistics manager started.");
Review comment:
actually it's stopped at this point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r744721458
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
Review comment:
commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745523382
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/StatisticsUtils.java
##########
@@ -172,4 +174,61 @@ public static StatisticsTarget statisticsTarget(StatisticsKeyMessage msg) {
String[] cols = (msg.colNames() == null) ? null : msg.colNames().toArray(new String[0]);
return new StatisticsTarget(msg.schema(), msg.obj(), cols);
}
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ * It means that specified statistics contains all columns with at least versions
+ * from specified map.
+ *
+ * @param stat Statistics to check. Can be {@code null}.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ public static int compareVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return -1;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
Review comment:
It cannot compare statistics from two different branches (col1v=1, col2v=2) and (col1v=2, col2v=1). I mean - if one cannot be calculated from other just by adding versions for some column. And such situation is impossible because of global meta storage and tombstones. But for statistics from the same "branch" it is enough to find first non equal version to get the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745551699
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Started flag. */
+ private boolean started;
+
+ /** Exchange listener: clean inbound requests and restart outbount. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+
+ Set<StatisticsKey> curColls = curCollections.keySet();
+
+ for (StatisticsKey key : curColls) {
+ curCollections.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+
+ Set<StatisticsKey> outReqs = outGlobalStatisticsRequests.keySet();
+
+ for (StatisticsKey key : outReqs) {
+ outGlobalStatisticsRequests.remove(key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+ }
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param statMgr Statistics manager.
+ * @param sysViewMgr System view manager.
+ //* @param statProc Statistics processor.
+ * @param mgmtPool Statistics management pool.
+ * @param discoMgr Grid discovery manager.
+ * @param cluster Cluster state processor.
+ * @param exchange Partition exchange manager.
+ * @param helper Statistics helper.
+ * @param ioMgr Communication manager.
+ * @param logSupplier Log supplier.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsManagerImpl statMgr,
+ GridSystemViewManager sysViewMgr,
+ //StatisticsProcessor statProc,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.statMgr = statMgr;
+ //this.statProc = statProc;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ statMgr.subscribeToLocalStatistics(nls -> onLocalStatisticsAggregated(nls.get1(), nls.get2(), nls.get3()));
+ statMgr.subscribeToStatisticsConfig(this::onConfigChanged);
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /**
+ * Start operations.
+ * Shouldn't be called twice.
+ */
+ public synchronized void start() {
+ if (started) {
+ if (log.isDebugEnabled())
+ log.debug("IgniteGlobalStatisticsManager already started.");
+
+ return;
+ }
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
Review comment:
because I have no dedicated locks and some local responses can finish processing right after stop and populate some "old" global statistics in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745546736
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,1026 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Global statistics manager. Cache global statistics and collect it.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics manager. */
+ private final IgniteStatisticsManagerImpl statMgr;
+
+ /** Statistics gatherer. */
+ //private final StatisticsProcessor statProc;
Review comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745544760
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsRepository.java
##########
@@ -320,4 +347,51 @@ public void saveObsolescenceInfo(StatisticsKey key) {
}
});
}
+
+ /**
+ * Subscribe to all local statistics changes.
+ *
+ * @param subscriber Local statitics subscriber.
+ */
+ public void subscribeToLocalStatistics(
+ Consumer<GridTuple3<StatisticsKey, ObjectStatisticsImpl, AffinityTopologyVersion>> subscriber
Review comment:
Replaced with new ObjectStatisticsEvent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r706100847
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
Review comment:
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r706107593
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsViewsPersistenceTest.java
##########
@@ -29,13 +27,6 @@
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
- cfg.setConsistentId(igniteInstanceName);
-
- DataStorageConfiguration memCfg = new DataStorageConfiguration()
- .setDefaultDataRegionConfiguration(new DataRegionConfiguration().setPersistenceEnabled(true));
-
- cfg.setDataStorageConfiguration(memCfg);
-
- return cfg;
+ return addPersistence(cfg, igniteInstanceName);
Review comment:
```suggestion
return addPersistentRegion(cfg, igniteInstanceName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r708242553
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsManagerImpl.java
##########
@@ -158,6 +162,22 @@ else if (db == null)
ctx::log
);
+ globalStatsMgr = new IgniteGlobalStatisticsManager(
+ statCfgMgr,
+ ctx.systemView(),
+ statsRepos,
+ gatherer,
+ mgmtPool,
+ ctx.discovery(),
+ ctx.state(),
+ ctx.cache().context().exchange(),
+ helper,
+ ctx.io(),
+ ctx::log);
+
+ statsRepos.setGlobalStatMgr(globalStatsMgr);
Review comment:
is it possible to avoid circular dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r706107265
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsViewsInMemoryTest.java
##########
@@ -29,13 +27,6 @@
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
- cfg.setConsistentId(igniteInstanceName);
-
- DataStorageConfiguration memCfg = new DataStorageConfiguration()
- .setDefaultDataRegionConfiguration(new DataRegionConfiguration().setPersistenceEnabled(false));
-
- cfg.setDataStorageConfiguration(memCfg);
-
- return cfg;
+ return addImMemory(cfg, igniteInstanceName);
Review comment:
```suggestion
return addInMemory(cfg, igniteInstanceName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r745553832
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/StatisticsUtils.java
##########
@@ -172,4 +174,61 @@ public static StatisticsTarget statisticsTarget(StatisticsKeyMessage msg) {
String[] cols = (msg.colNames() == null) ? null : msg.colNames().toArray(new String[0]);
return new StatisticsTarget(msg.schema(), msg.obj(), cols);
}
+
+ /**
+ * Test if specified statistics is fit to all required versions.
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 merged pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
korlov42 merged pull request #9392:
URL: https://github.com/apache/ignite/pull/9392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Berkof commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r741864717
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
Review comment:
Done
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/BusyExecutor.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.internal.util.GridBusyLock;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Executor with busy run support.
+ * Can run any tasks while active and safelly wait untill they stopped.
+ */
+public class BusyExecutor {
Review comment:
How we can wrap each runnable with a busy lock? We need one lock to allow graceful shutdown and that lock is located in BusyExecutor.
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteGlobalStatisticsManager.java
##########
@@ -0,0 +1,985 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.events.DiscoveryEvent;
+import org.apache.ignite.internal.GridTopic;
+import org.apache.ignite.internal.events.DiscoveryCustomEvent;
+import org.apache.ignite.internal.managers.communication.GridIoManager;
+import org.apache.ignite.internal.managers.communication.GridIoPolicy;
+import org.apache.ignite.internal.managers.communication.GridMessageListener;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
+import org.apache.ignite.internal.managers.systemview.GridSystemViewManager;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnGlobalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnLocalDataViewWalker;
+import org.apache.ignite.internal.managers.systemview.walker.StatisticsColumnPartitionDataViewWalker;
+import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
+import org.apache.ignite.internal.processors.cache.CacheGroupContext;
+import org.apache.ignite.internal.processors.cache.DynamicCacheChangeBatch;
+import org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture;
+import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware;
+import org.apache.ignite.internal.processors.cluster.GridClusterStateProcessor;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsColumnConfiguration;
+import org.apache.ignite.internal.processors.query.stat.config.StatisticsObjectConfiguration;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsKeyMessage;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsObjectData;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsRequest;
+import org.apache.ignite.internal.processors.query.stat.messages.StatisticsResponse;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnConfigurationView;
+import org.apache.ignite.internal.processors.query.stat.view.StatisticsColumnGlobalDataView;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * TODO: TBD
+ * Crawler to track and handle any requests, related to statistics.
+ * Crawler tracks requests and call back statistics manager to process failed requests.
+ */
+public class IgniteGlobalStatisticsManager implements GridMessageListener {
+ /** */
+ private static final String STAT_GLOBAL_VIEW_NAME = "statisticsGlobalData";
+
+ /** */
+ private static final String STAT_GLOBAL_VIEW_DESCRIPTION = "Global statistics.";
+
+ /** Statistics configuration manager. */
+ private final IgniteStatisticsConfigurationManager cfgMgr;
+
+ /** Statistics repository. */
+ private final IgniteStatisticsRepository repo;
+
+ /** Statistics gatherer. */
+ private final StatisticsGatherer gatherer;
+
+ /** Pool to process statistics requests. */
+ private final IgniteThreadPoolExecutor mgmtPool;
+
+ /** Discovery manager to get server node list to statistics master calculation. */
+ private final GridDiscoveryManager discoMgr;
+
+ /** Cluster state processor. */
+ private final GridClusterStateProcessor cluster;
+
+ /** Cache partition exchange manager. */
+ private final GridCachePartitionExchangeManager<?, ?> exchange;
+
+ /** Helper to transform or generate statistics related messages. */
+ private final IgniteStatisticsHelper helper;
+
+ /** Grid io manager to exchange global and local statistics. */
+ private final GridIoManager ioMgr;
+
+ /** Cache for global statistics. */
+ private final ConcurrentMap<StatisticsKey, CacheEntry<ObjectStatisticsImpl>> globalStatistics =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after local statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inLocalRequests =
+ new ConcurrentHashMap<>();
+
+ /** Incoming requests which should be served after global statistics collection finish. */
+ private final ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> inGloblaRequests =
+ new ConcurrentHashMap<>();
+
+ /** Outcoming global collection requests. */
+ private final ConcurrentMap<StatisticsKey, StatisticsGatheringContext> curCollections = new ConcurrentHashMap<>();
+
+ /** Outcoming global statistics requests to request id. */
+ private final ConcurrentMap<StatisticsKey, UUID> outGlobalStatisticsRequests = new ConcurrentHashMap<>();
+
+ /** Actual topology version for all pending requests. */
+ private volatile AffinityTopologyVersion topVer;
+
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /** Exchange listener. */
+ private final PartitionsExchangeAware exchAwareLsnr = new PartitionsExchangeAware() {
+ @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) {
+
+ // Skip join/left client nodes.
+ if (fut.exchangeType() != GridDhtPartitionsExchangeFuture.ExchangeType.ALL ||
+ cluster.clusterState().lastState() != ClusterState.ACTIVE)
+ return;
+
+ DiscoveryEvent evt = fut.firstEvent();
+
+ // Skip create/destroy caches.
+ if (evt.type() == DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT) {
+ DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)evt).customMessage();
+
+ if (msg instanceof DynamicCacheChangeBatch)
+ return;
+
+ // Just clear all activities and update topology version.
+ if (log.isDebugEnabled())
+ log.debug("Resetting all global statistics activities due to new topology " +
+ fut.topologyVersion());
+
+ inLocalRequests.clear();
+ inGloblaRequests.clear();
+ curCollections.clear();
+ outGlobalStatisticsRequests.clear();
+
+ topVer = fut.topologyVersion();
+ }
+ }
+ };
+
+ /**
+ * Constructor.
+ *
+ * @param cfgMgr Statistics configuration manager.
+ */
+ public IgniteGlobalStatisticsManager(
+ IgniteStatisticsConfigurationManager cfgMgr,
+ GridSystemViewManager sysViewMgr,
+ IgniteStatisticsRepository repo,
+ StatisticsGatherer gatherer,
+ IgniteThreadPoolExecutor mgmtPool,
+ GridDiscoveryManager discoMgr,
+ GridClusterStateProcessor cluster,
+ GridCachePartitionExchangeManager<?, ?> exchange,
+ IgniteStatisticsHelper helper,
+ GridIoManager ioMgr,
+ Function<Class<?>, IgniteLogger> logSupplier
+ ) {
+ this.cfgMgr = cfgMgr;
+ this.repo = repo;
+ this.gatherer = gatherer;
+ this.mgmtPool = mgmtPool;
+ this.discoMgr = discoMgr;
+ this.cluster = cluster;
+ this.exchange = exchange;
+ this.helper = helper;
+ this.ioMgr = ioMgr;
+ log = logSupplier.apply(IgniteGlobalStatisticsManager.class);
+
+ ioMgr.addMessageListener(GridTopic.TOPIC_STATISTICS, this);
+
+ sysViewMgr.registerFiltrableView(STAT_GLOBAL_VIEW_NAME, STAT_GLOBAL_VIEW_DESCRIPTION,
+ new StatisticsColumnGlobalDataViewWalker(), this::columnGlobalStatisticsViewSupplier, Function.identity());
+ }
+
+ /**
+ * Statistics column global data view filterable supplier.
+ *
+ * @param filter Filter.
+ * @return Iterable with statistics column global data views.
+ */
+ private Iterable<StatisticsColumnGlobalDataView> columnGlobalStatisticsViewSupplier(Map<String, Object> filter) {
+ String type = (String)filter.get(StatisticsColumnPartitionDataViewWalker.TYPE_FILTER);
+ if (type != null && !StatisticsColumnConfigurationView.TABLE_TYPE.equalsIgnoreCase(type))
+ return Collections.emptyList();
+
+ String schema = (String)filter.get(StatisticsColumnLocalDataViewWalker.SCHEMA_FILTER);
+ String name = (String)filter.get(StatisticsColumnLocalDataViewWalker.NAME_FILTER);
+ String column = (String)filter.get(StatisticsColumnPartitionDataViewWalker.COLUMN_FILTER);
+
+ Map<StatisticsKey, ObjectStatisticsImpl> globalStatsMap;
+ if (!F.isEmpty(schema) && !F.isEmpty(name)) {
+ StatisticsKey key = new StatisticsKey(schema, name);
+
+ CacheEntry<ObjectStatisticsImpl> objLocStat = globalStatistics.get(key);
+
+ if (objLocStat == null || objLocStat.obj == null)
+ return Collections.emptyList();
+
+ globalStatsMap = Collections.singletonMap(key, objLocStat.object());
+ }
+ else
+ globalStatsMap = globalStatistics.entrySet().stream()
+ .filter(e -> e.getValue().object() != null && (F.isEmpty(schema) || schema.equals(e.getKey().schema())))
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().object()));
+
+ List<StatisticsColumnGlobalDataView> res = new ArrayList<>();
+
+ for (Map.Entry<StatisticsKey, ObjectStatisticsImpl> localStatsEntry : globalStatsMap.entrySet()) {
+ StatisticsKey key = localStatsEntry.getKey();
+ ObjectStatisticsImpl stat = localStatsEntry.getValue();
+
+ if (column == null) {
+ for (Map.Entry<String, ColumnStatistics> colStat : localStatsEntry.getValue().columnsStatistics()
+ .entrySet()) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key,
+ colStat.getKey(), stat);
+
+ res.add(colStatView);
+ }
+ }
+ else {
+ ColumnStatistics colStat = localStatsEntry.getValue().columnStatistics(column);
+
+ if (colStat != null) {
+ StatisticsColumnGlobalDataView colStatView = new StatisticsColumnGlobalDataView(key, column, stat);
+
+ res.add(colStatView);
+ }
+ }
+ }
+
+ return res;
+ }
+
+ /** Start. */
+ public void start() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager starting...");
+
+ globalStatistics.clear();
+ exchange.registerExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager started.");
+ }
+
+ /** Stop. */
+ public void stop() {
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopping...");
+
+ topVer = null;
+
+ globalStatistics.clear();
+
+ inGloblaRequests.clear();
+ inLocalRequests.clear();
+ outGlobalStatisticsRequests.clear();
+ curCollections.clear();
+
+ exchange.unregisterExchangeAwareComponent(exchAwareLsnr);
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics manager stopped.");
+ }
+
+ /**
+ * Get global statistics for the given key. If there is no cached statistics, but
+ *
+ * @param key Statistics key.
+ * @return Global object statistics or {@code null} if there is no global statistics available.
+ */
+ public ObjectStatisticsImpl getGlobalStatistics(StatisticsKey key) {
+ CacheEntry<ObjectStatisticsImpl> res = globalStatistics.computeIfAbsent(key, k -> {
+ if (log.isDebugEnabled())
+ log.debug("Scheduling global statistics collection by key " + key);
+
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return new CacheEntry<>(null);
+ });
+
+ return res.object();
+ }
+
+ /**
+ * Either send local or global statistics request to get global statistics.
+ *
+ * @param key Statistics key to get global statistics by.
+ */
+ private void collectGlobalStatistics(StatisticsKey key) {
+ try {
+ StatisticsObjectConfiguration statCfg = cfgMgr.config(key);
+
+ if (statCfg != null && !statCfg.columns().isEmpty()) {
+ UUID statMaster = getStatisticsMasterNode(key);
+
+ if (discoMgr.localNode().id().equals(statMaster))
+ gatherGlobalStatistics(statCfg);
+ else {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(),
+ Collections.emptyList());
+
+ Map<String, Long> versions = statCfg.columns().entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().version()));
+
+ StatisticsRequest globalReq = new StatisticsRequest(UUID.randomUUID(), keyMsg,
+ StatisticsType.GLOBAL, null, versions);
+
+ outGlobalStatisticsRequests.put(key, globalReq.reqId());
+
+ if (log.isDebugEnabled())
+ log.debug("Send global statistics request by configuration " + statCfg);
+
+ send(statMaster, globalReq);
+
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Unable to start global statistics collection due to lack of configuration by key "
+ + key);
+ }
+
+ }
+ catch (IgniteCheckedException e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to get statistics configuration due to " + e.getMessage());
+ }
+ }
+
+ /**
+ * Collect global statistics on master node.
+ *
+ * @param statCfg Statistics config to gather global statistics by.
+ */
+ private void gatherGlobalStatistics(StatisticsObjectConfiguration statCfg) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Start global statistics collection by configuration " + statCfg);
+
+ StatisticsTarget target = new StatisticsTarget(statCfg.key());
+
+ List<StatisticsAddressedRequest> locRequests = helper.generateGatheringRequests(target, statCfg);
+ UUID reqId = locRequests.get(0).req().reqId();
+
+ StatisticsGatheringContext gatCtx = new StatisticsGatheringContext(locRequests.size(), reqId);
+
+ curCollections.put(statCfg.key(), gatCtx);
+
+ for (StatisticsAddressedRequest addReq : locRequests) {
+ if (log.isDebugEnabled())
+ log.debug("Sending local request " + addReq.req().reqId() + " to node " + addReq.nodeId());
+
+ send(addReq.nodeId(), addReq.req());
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onMessage(UUID nodeId, Object msg, byte plc) {
+ mgmtPool.submit(() -> {
+ try {
+ if (msg instanceof StatisticsRequest) {
+ StatisticsRequest req = (StatisticsRequest)msg;
+ switch (req.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, req);
+
+ break;
+
+ case GLOBAL:
+ processGlobalRequest(nodeId, req);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + req.type() + " in statistics request message " + req);
+ }
+ }
+ else if (msg instanceof StatisticsResponse) {
+ StatisticsResponse resp = (StatisticsResponse)msg;
+
+ switch (resp.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, resp);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, resp);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + resp.data().type() +
+ " in statistics reposonse message " + resp);
+ }
+
+ }
+ else
+ log.warning("Unknown msg " + msg + " in statistics topic " + GridTopic.TOPIC_STATISTICS +
+ " from node " + nodeId);
+ }
+ catch (Throwable e) {
+ if (log.isInfoEnabled())
+ log.info("Unable to process statistics message: " + e);
+ }
+ });
+ }
+
+ private void getTopVer(StatisticsKey key) {
+
+ }
+
+ /**
+ * Process request for local statistics.
+ * 1) If there are local statistics for the given key - send response.
+ * 2) If there is no such statistics - add request to incoming queue.
+ * @param nodeId Sender node id.
+ * @param req Request to process.
+ * @throws IgniteCheckedException
+ */
+ private void processLocalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+ ObjectStatisticsImpl objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions()))
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ else {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+ CacheGroupContext grpCtx = helper.getGroupContext(key);
+ AffinityTopologyVersion topVer = grpCtx.affinity().lastVersion();
+
+ addToRequests(inLocalRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ if (checkStatisticsCfg(cfg, req.versions()) && topVer.compareTo(req.topVer()) >= 0) {
+ cfgMgr.checkLocalStatistics(cfg, topVer);
+ LocalStatisticsGatheringContext ctx = gatherer.gatheringInProgress(cfg.key());
+
+ if (ctx != null)
+ // If there is no context = aggregation finished and data will be send at double check below
+ ctx.futureAggregate().thenAccept(stat -> onLocalStatisticsAggregated(key, stat, topVer));
+ }
+
+ // Double check that we have no race with collection finishing.
+ objectStatistics = repo.getLocalStatistics(key, req.topVer());
+
+ if (checkStatisticsVersions(objectStatistics, req.versions())) {
+ StatisticsAddressedRequest removedReq = removeFromRequests(inLocalRequests, key, req.reqId());
+
+ if (removedReq != null)
+ sendResponse(nodeId, removedReq.req().reqId(), key, StatisticsType.LOCAL, objectStatistics);
+ // else was already processed by on collect handler.
+ }
+ }
+ }
+
+ /**
+ * Test if statistics configuration is fit to all required versions.
+ * @param cfg Statistics configuration to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsCfg(StatisticsObjectConfiguration cfg, Map<String, Long> versions) {
+ if (cfg == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ StatisticsColumnConfiguration colCfg = cfg.columns().get(version.getKey());
+
+ if (colCfg == null || colCfg.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Test if specified statistics is fit to all required versions.
+ *
+ * @param stat Statistics to check.
+ * @param versions Map of column name to required version.
+ * @return {@code true} if it is, {@code false} otherwise.
+ */
+ private boolean checkStatisticsVersions(
+ ObjectStatisticsImpl stat,
+ Map<String, Long> versions
+ ) {
+ if (stat == null)
+ return false;
+
+ for (Map.Entry<String, Long> version : versions.entrySet()) {
+ ColumnStatistics colStat = stat.columnsStatistics().get(version.getKey());
+
+ if (colStat == null || colStat.version() < version.getValue())
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
+ * Process incoming request for global statistics. Either response (if it exists), or collect and response
+ * (if current node is master node for the given key) or ignore (if current node is no more master node for
+ * the given key.
+ *
+ * @param nodeId Sender node id.
+ * @param req Request.
+ */
+ private void processGlobalRequest(UUID nodeId, StatisticsRequest req) throws IgniteCheckedException {
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics request from node " + nodeId + " : " + req);
+
+ StatisticsKey key = new StatisticsKey(req.key().schema(), req.key().obj());
+
+ CacheEntry<ObjectStatisticsImpl> objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry == null || objectStatisticsEntry.object() == null
+ || !checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ if (discoMgr.localNode().id().equals(getStatisticsMasterNode(key))) {
+ addToRequests(inGloblaRequests, key, new StatisticsAddressedRequest(req, nodeId));
+
+ collectGlobalStatistics(new StatisticsKey(req.key().schema(), req.key().obj()));
+ }
+
+ objectStatisticsEntry = globalStatistics.get(key);
+
+ if (objectStatisticsEntry != null && objectStatisticsEntry.object() != null
+ && checkStatisticsVersions(objectStatisticsEntry.object(), req.versions())) {
+ StatisticsAddressedRequest removed = removeFromRequests(inGloblaRequests, key, req.reqId());
+
+ if (removed != null)
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+ }
+ else
+ sendResponse(nodeId, req.reqId(), key, StatisticsType.GLOBAL, objectStatisticsEntry.object());
+ }
+
+ /**
+ * Build statistics response and send it to specified node.
+ *
+ * @param nodeId Target node id.
+ * @param reqId Request id.
+ * @param key Statistics key.
+ * @param type Statistics type.
+ * @param data Statitsics data.
+ */
+ private void sendResponse(
+ UUID nodeId,
+ UUID reqId,
+ StatisticsKey key,
+ StatisticsType type,
+ ObjectStatisticsImpl data
+ ) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = new StatisticsKeyMessage(key.schema(), key.obj(), null);
+ StatisticsObjectData dataMsg = StatisticsUtils.toObjectData(keyMsg, type, data);
+
+ send(nodeId, new StatisticsResponse(reqId, dataMsg));
+ }
+
+ /**
+ * Add to addressed requests map.
+ *
+ * @param map Map to add into.
+ * @param key Request statistics key.
+ * @param req Request to add.
+ */
+ private void addToRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ StatisticsAddressedRequest req
+ ) {
+ map.compute(key, (k, v) -> {
+ if (v == null)
+ v = new ArrayList<>();
+
+ v.add(req);
+
+ return v;
+ });
+ }
+
+ /**
+ * Check if specified map contains request with specified key and id, remove and return it.
+ *
+ * @param key Request statistics key.
+ * @param reqId Request id.
+ * @return Removed request.
+ */
+ private StatisticsAddressedRequest removeFromRequests(
+ ConcurrentMap<StatisticsKey, Collection<StatisticsAddressedRequest>> map,
+ StatisticsKey key,
+ UUID reqId
+ ) {
+ StatisticsAddressedRequest[] res = new StatisticsAddressedRequest[1];
+
+ map.compute(key, (k, v) -> {
+ if (v != null)
+ res[0] = v.stream().filter(e -> reqId.equals(e.req().reqId())).findAny().orElse(null);
+
+ if (res[0] != null)
+ v = v.stream().filter(e -> !reqId.equals(e.req().reqId())).collect(Collectors.toList());
+
+ return v;
+ });
+
+ return res[0];
+ }
+
+ /**
+ * Process statistics configuration changes:
+ *
+ * 1) Remove all current activity by specified key.
+ * 2) If there are no live columns config - remove cached global statistics.
+ * 3) If there are some live columns config and global statistics cache contains statistics for the given key -
+ * start to collect it again.
+ */
+ public void onConfigChanged(StatisticsObjectConfiguration cfg) {
+ StatisticsKey key = cfg.key();
+
+ inLocalRequests.remove(key);
+ inGloblaRequests.remove(key);
+ curCollections.remove(key);
+ outGlobalStatisticsRequests.remove(key);
+
+ if (cfg.columns().isEmpty())
+ globalStatistics.remove(key);
+ else {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ if (v != null)
+ mgmtPool.submit(() -> collectGlobalStatistics(key));
+
+ return v;
+ });
+ }
+ }
+
+ /**
+ * Clear global object statistics.
+ *
+ * @param key Object key to clear blobal statistics by.
+ * @param colNames Only statistics by specified columns will be cleared.
+ */
+ public void clearGlobalStatistics(StatisticsKey key, Set<String> colNames) {
+ globalStatistics.computeIfPresent(key, (k, v) -> {
+ ObjectStatisticsImpl globStatOld = v.object();
+ ObjectStatisticsImpl globStatNew = (globStatOld == null) ? null : globStatOld.subtract(colNames);
+
+ return (globStatNew == null || globStatNew.columnsStatistics().isEmpty()) ? null :
+ new CacheEntry<>(v.cachedAt(), globStatNew);
+ });
+
+ outGlobalStatisticsRequests.remove(key);
+ }
+
+ /**
+ * Process response with local statistics. Try to finish collecting operation and send pending requests.
+ *
+ * @param nodeId Sender node id.
+ * @param resp Statistics response to process.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processLocalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), resp.data().key().obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got local statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ StatisticsGatheringContext curCtx = curCollections.get(key);
+
+ if (curCtx != null) {
+ if (!curCtx.reqId().equals(resp.reqId())) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp + " instead of " + curCtx.reqId());
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ if (curCtx.registerResponse(data)) {
+ StatisticsObjectConfiguration cfg = cfgMgr.config(key);
+
+ if (cfg != null) {
+ if (log.isDebugEnabled())
+ log.debug("Aggregating global statistics for key " + key + " by request " + curCtx.reqId());
+
+ ObjectStatisticsImpl globalStat = helper.aggregateLocalStatistics(cfg, curCtx.collectedData());
+
+ globalStatistics.put(key, new CacheEntry<>(globalStat));
+
+ if (log.isDebugEnabled())
+ log.debug("Global statistics for key " + key + " collected.");
+
+ Collection<StatisticsAddressedRequest> globalRequests = inGloblaRequests.remove(key);
+
+ if (globalRequests != null) {
+ StatisticsObjectData globalStatData = StatisticsUtils.toObjectData(keyMsg,
+ StatisticsType.GLOBAL, globalStat);
+
+ for (StatisticsAddressedRequest req : globalRequests) {
+ StatisticsResponse outResp = new StatisticsResponse(req.req().reqId(), globalStatData);
+
+ send(req.nodeId(), outResp);
+ }
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Dropping collected statistics due to lack of configuration for key " + key);
+ }
+
+ curCollections.remove(key);
+ }
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated local statistics response " + resp);
+ }
+ }
+
+ /**
+ * Process response of global statistics.
+ *
+ * @param resp Response.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void processGlobalResponse(UUID nodeId, StatisticsResponse resp) throws IgniteCheckedException {
+ StatisticsKeyMessage keyMsg = resp.data().key();
+ StatisticsKey key = new StatisticsKey(keyMsg.schema(), keyMsg.obj());
+
+ if (log.isDebugEnabled())
+ log.debug("Got global statistics response " + resp.reqId() + " from node " + nodeId + " by key " + key);
+
+ UUID reqId = outGlobalStatisticsRequests.get(key);
+
+ if (reqId != null) {
+ if (!resp.reqId().equals(reqId)) {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp + " instead of " + reqId);
+
+ return;
+ }
+
+ ObjectStatisticsImpl data = StatisticsUtils.toObjectStatistics(null, resp.data());
+
+ globalStatistics.put(key, new CacheEntry(data));
+ outGlobalStatisticsRequests.remove(key);
+ }
+ else {
+ if (log.isDebugEnabled())
+ log.debug("Got outdated global statistics response " + resp);
+ }
+ }
+
+ /**
+ * Calculate id of statistics master node for the given key.
+ *
+ * @param key Statistics key to calculate master node for.
+ * @return if of statistics master node.
+ */
+ private UUID getStatisticsMasterNode(StatisticsKey key) {
+ UUID[] nodes = discoMgr.aliveServerNodes().stream().map(ClusterNode::id).sorted().toArray(UUID[]::new);
+ int idx = IgniteUtils.hashToIndex(key.obj().hashCode(), nodes.length);
+
+ return nodes[idx];
+ }
+
+ /**
+ * After collecting local statistics - check if there are some pending request for it and send responces.
+ *
+ * @param key Statistics key on which local statistics was aggregated.
+ * @param statistics Collected statistics by key.
+ * @param topVer Topology version which aggregated statistics stands for.
+ */
+ public void onLocalStatisticsAggregated(
+ StatisticsKey key,
+ ObjectStatisticsImpl statistics,
+ AffinityTopologyVersion topVer
+ ) {
+ if (topVer == null)
+ return;
+
+ List<StatisticsAddressedRequest> inReqs[] = new List[1];
+
+ inLocalRequests.computeIfPresent(key, (k, v) -> {
+ List<StatisticsAddressedRequest> left = new ArrayList<>();
+ inReqs[0] = new ArrayList<>();
+
+ for (StatisticsAddressedRequest req : v) {
+ if (topVer.equals(req.req().topVer()))
+ inReqs[0].add(req);
+ else
+ left.add(req);
+ }
+
+ return (left.isEmpty()) ? null : left;
+ });
+
+ if (inReqs[0] == null)
+ return;
+
+ for (StatisticsAddressedRequest req : inReqs[0]) {
+ try {
+ sendResponse(req.nodeId(), req.req().reqId(), key, StatisticsType.LOCAL, statistics);
+ }
+ catch (IgniteCheckedException e) {
+ log.info("Unable to send local object statistics for key " + key + " due to " + e.getMessage());
+ }
+ }
+ }
+
+ /**
+ * Send statistics related message.
+ *
+ * @param nodeId Target node id.
+ * @param msg Message to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsRequest msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.type()) {
+ case LOCAL:
+ processLocalRequest(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.type() + " in statistics request message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /**
+ * Send statistics response or process it locally.
+ *
+ * @param nodeId Target node id. If equals to local node - corresponding method will be called directly.
+ * @param msg Statistics response to send.
+ * @throws IgniteCheckedException In case of error.
+ */
+ private void send(UUID nodeId, StatisticsResponse msg) throws IgniteCheckedException {
+ if (discoMgr.localNode().id().equals(nodeId)) {
+ switch (msg.data().type()) {
+ case LOCAL:
+ processLocalResponse(nodeId, msg);
+
+ break;
+
+ case GLOBAL:
+ processGlobalResponse(nodeId, msg);
+
+ break;
+
+ default:
+ log.warning("Unexpected type " + msg.data().type() + " in statistics response message " + msg);
+ }
+ }
+ else
+ ioMgr.sendToGridTopic(nodeId, GridTopic.TOPIC_STATISTICS, msg, GridIoPolicy.MANAGEMENT_POOL);
+ }
+
+ /** Cache entry. */
+ private static class CacheEntry<T> {
+ /** Cache entry original timestamp. */
+ private final long cachedAt;
+
+ /** Cached object. */
+ private final T obj;
+
+ /**
+ * Constructor.
+ *
+ * @param obj Cached object.
+ */
+ public CacheEntry(T obj) {
+ cachedAt = System.currentTimeMillis();
+ this.obj = obj;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param cachedAt Cache original timestamp.
+ * @param obj Object to cache.
+ */
+ public CacheEntry(long cachedAt, T obj) {
+ this.cachedAt = cachedAt;
+ this.obj = obj;
+ }
+
+ /**
+ * @return Cache entry original timestamp.
+ */
+ public long cachedAt() {
+ return cachedAt;
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #9392: IGNITE-15289 Global statistics collection
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r736322118
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/BusyExecutor.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.internal.util.GridBusyLock;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Executor with busy run support.
+ * Can run any tasks while active and safelly wait untill they stopped.
+ */
+public class BusyExecutor {
Review comment:
Why not just wrap runnables with busy lock instead of wrapping an executor?
Now, object lifecycle doesn't look clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org