You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/01/22 07:42:15 UTC
[GitHub] [trafficserver] vmamidi opened a new pull request #7439: API to retrieve NoStore set by plugins
vmamidi opened a new pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#issuecomment-772901054
Cherry-picked to v9.1.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#issuecomment-772051794
Should these also be described in the docs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi commented on pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
vmamidi commented on pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#issuecomment-772062052
> Should this also be described in the docs?
Ideally, yes. I didn't do it as TSHttpTxnServerRespNoStoreSet also isn't documented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#discussion_r568975330
##########
File path: src/traffic_server/InkAPI.cc
##########
@@ -5596,6 +5596,15 @@ TSHttpTxnServerRespNoStoreSet(TSHttpTxn txnp, int flag)
return TS_SUCCESS;
}
+bool
+TSHttpTxnServerRespNoStoreGet(TSHttpTxn txnp)
+{
+ sdk_assert(sdk_sanity_check_txn(txnp) == TS_SUCCESS);
+
+ HttpTransact::State *s = &(((HttpSM *)txnp)->t_state);
Review comment:
nitpick: C cast
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#discussion_r568975330
##########
File path: src/traffic_server/InkAPI.cc
##########
@@ -5596,6 +5596,15 @@ TSHttpTxnServerRespNoStoreSet(TSHttpTxn txnp, int flag)
return TS_SUCCESS;
}
+bool
+TSHttpTxnServerRespNoStoreGet(TSHttpTxn txnp)
+{
+ sdk_assert(sdk_sanity_check_txn(txnp) == TS_SUCCESS);
+
+ HttpTransact::State *s = &(((HttpSM *)txnp)->t_state);
Review comment:
nitpick: C cast
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi commented on pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
vmamidi commented on pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#issuecomment-772062052
> Should this also be described in the docs?
Ideally, yes. I didn't do it as TSHttpTxnServerRespNoStoreSet also isn't documented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#issuecomment-772051794
Should these also be described in the docs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras edited a comment on pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
ywkaras edited a comment on pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#issuecomment-772051794
Should this also be described in the docs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras edited a comment on pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
ywkaras edited a comment on pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439#issuecomment-772051794
Should this also be described in the docs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi merged pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
vmamidi merged pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi merged pull request #7439: API to retrieve NoStore set by plugins
Posted by GitBox <gi...@apache.org>.
vmamidi merged pull request #7439:
URL: https://github.com/apache/trafficserver/pull/7439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org