You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "zhaoyongjie (via GitHub)" <gi...@apache.org> on 2023/06/08 18:52:12 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request, #24328: Draft: fix Time Shift join key
zhaoyongjie opened a new pull request, #24328:
URL: https://github.com/apache/superset/pull/24328
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #24328: Draft: fix Time Shift join key
Posted by "zhaoyongjie (via GitHub)" <gi...@apache.org>.
zhaoyongjie commented on PR #24328:
URL: https://github.com/apache/superset/pull/24328#issuecomment-1623617201
Hey @villebro, this PR was part of review for #24176 and the discussion with @michael-s-molina at https://github.com/apache/superset/pull/24176#issuecomment-1583244689 and https://github.com/apache/superset/pull/24176#issuecomment-1583254732.
From my personal perspective, I don't [quite comprehend the modifications](https://github.com/apache/superset/pull/24176/files#diff-78bc33ba8d00e5542bf3be36e1f9f9ecd6bd7272c929dc03ea149d373a17fc5a) made on the master branch and the habit of [hardcoding in the codebase](https://github.com/michael-s-molina/incubator-superset/blob/13ed8300debf6b9e3228ef8c6b91087fc8d92491/superset/common/query_context_processor.py#L535) and [here](https://github.com/michael-s-molina/incubator-superset/blob/13ed8300debf6b9e3228ef8c6b91087fc8d92491/superset/common/query_context_processor.py#L340).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24328: Draft: fix Time Shift join key
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24328:
URL: https://github.com/apache/superset/pull/24328#issuecomment-1621056485
@zhaoyongjie is this fix needed upstream? Do you have a test case that shows the problem and is fixed by this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed pull request #24328: Draft: fix Time Shift join key
Posted by "zhaoyongjie (via GitHub)" <gi...@apache.org>.
zhaoyongjie closed pull request #24328: Draft: fix Time Shift join key
URL: https://github.com/apache/superset/pull/24328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #24328: Draft: fix Time Shift join key
Posted by "zhaoyongjie (via GitHub)" <gi...@apache.org>.
zhaoyongjie commented on PR #24328:
URL: https://github.com/apache/superset/pull/24328#issuecomment-1620706342
Will cherry-pick this one, close it in community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24328: Draft: fix Time Shift join key
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24328:
URL: https://github.com/apache/superset/pull/24328#issuecomment-1583178759
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24328](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (585124f) into [master](https://app.codecov.io/gh/apache/superset/commit/f5148ef728ce649697c10fb7aa65982d7dd05638?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f5148ef) will **decrease** coverage by `10.29%`.
> The diff coverage is `35.89%`.
> :exclamation: Current head 585124f differs from pull request most recent head 96689b2. Consider uploading reports for the commit 96689b2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24328 +/- ##
===========================================
- Coverage 67.84% 57.56% -10.29%
===========================================
Files 1944 1943 -1
Lines 75328 75235 -93
Branches 8218 8216 -2
===========================================
- Hits 51110 43311 -7799
- Misses 22107 29813 +7706
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.60% <35.89%> (+0.06%)` | :arrow_up: |
| presto | `53.52% <35.89%> (+0.06%)` | :arrow_up: |
| python | `60.34% <35.89%> (-21.32%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.95% <35.89%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL05WRDNWaXMuanM=) | `0.00% <ø> (ø)` | |
| [...end/plugins/legacy-preset-chart-nvd3/src/preset.js](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3ByZXNldC5qcw==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `2.04% <ø> (ø)` | |
| [...dashboard/components/AddSliceCard/AddSliceCard.tsx](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC9BZGRTbGljZUNhcmQudHN4) | `65.11% <ø> (-0.80%)` | :arrow_down: |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `90.56% <ø> (-0.18%)` | :arrow_down: |
| [...dashboard/components/SliceHeaderControls/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | `69.79% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `57.52% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `75.00% <ø> (ø)` | |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `88.23% <ø> (ø)` | |
| [.../features/databases/DatabaseModal/ExtraOptions.tsx](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL0V4dHJhT3B0aW9ucy50c3g=) | `66.66% <ø> (+1.96%)` | :arrow_up: |
| ... and [9 more](https://app.codecov.io/gh/apache/superset/pull/24328?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [287 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24328/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org