You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by sw...@apache.org on 2026/10/21 05:02:28 UTC
(logging-log4cxx) branch suppress_unused_parameter_warning created (now 0f0a8316)
This is an automated email from the ASF dual-hosted git repository.
swebb2066 pushed a change to branch suppress_unused_parameter_warning
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git
at 0f0a8316 Ensure Log4cxx usage does not generate compiler warnings
This branch includes the following new commits:
new 0f0a8316 Ensure Log4cxx usage does not generate compiler warnings
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(logging-log4cxx) 01/01: Ensure Log4cxx usage does not generate compiler warnings
Posted by sw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
swebb2066 pushed a commit to branch suppress_unused_parameter_warning
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git
commit 0f0a8316f7b88366e2efa22d1aa4706c242fdfdf
Author: Stephen Webb <sw...@gmail.com>
AuthorDate: Wed Oct 21 16:01:39 2026 +1100
Ensure Log4cxx usage does not generate compiler warnings
---
src/examples/cpp/MyApp1.cpp | 2 +-
src/examples/cpp/MyApp2.cpp | 2 +-
src/examples/cpp/custom-appender.cpp | 5 +++--
src/main/cpp/CMakeLists.txt | 1 +
src/main/cpp/errorhandler.cpp | 4 ++++
src/main/cpp/{errorhandler.cpp => loggerrepository.cpp} | 14 +++++++++++---
src/main/include/log4cxx/spi/errorhandler.h | 2 +-
src/main/include/log4cxx/spi/loggerrepository.h | 6 +++---
8 files changed, 25 insertions(+), 11 deletions(-)
diff --git a/src/examples/cpp/MyApp1.cpp b/src/examples/cpp/MyApp1.cpp
index faf24938..5ce70d9a 100644
--- a/src/examples/cpp/MyApp1.cpp
+++ b/src/examples/cpp/MyApp1.cpp
@@ -14,7 +14,7 @@ void foo() {
LOG4CXX_FATAL(fooLogger, "Doing foo at fatal level");
}
-int main(int argc, char **argv) {
+int main() {
// Log to standard output.
log4cxx::BasicConfigurator::configure();
LOG4CXX_INFO(logger, "Entering application.");
diff --git a/src/examples/cpp/MyApp2.cpp b/src/examples/cpp/MyApp2.cpp
index 0c7baccc..f9c6f2ca 100644
--- a/src/examples/cpp/MyApp2.cpp
+++ b/src/examples/cpp/MyApp2.cpp
@@ -1,7 +1,7 @@
#include "com/foo/config.h"
#include "com/foo/bar.h"
-int main(int argc, char **argv) {
+int main() {
int result = EXIT_SUCCESS;
try {
auto logger = com::foo::getLogger("MyApp");
diff --git a/src/examples/cpp/custom-appender.cpp b/src/examples/cpp/custom-appender.cpp
index bb3c4d82..8495d125 100644
--- a/src/examples/cpp/custom-appender.cpp
+++ b/src/examples/cpp/custom-appender.cpp
@@ -38,7 +38,7 @@ public:
return false;
}
- void append( const log4cxx::spi::LoggingEventPtr& event ) override {
+ void append( const log4cxx::spi::LoggingEventPtr& ) override {
// This gets called whenever there is a valid event for our appender.
}
@@ -54,6 +54,7 @@ public:
))
{
// Do something with the 'value' here.
+ (void)value;
}
}
};
@@ -62,7 +63,7 @@ IMPLEMENT_LOG4CXX_OBJECT(NullWriterAppender)
}
-int main( int argc, char** argv )
+int main()
{
LOG4CXX_NS::xml::DOMConfigurator::configure( "custom-appender.xml" );
diff --git a/src/main/cpp/CMakeLists.txt b/src/main/cpp/CMakeLists.txt
index 063b5aa9..341412dc 100644
--- a/src/main/cpp/CMakeLists.txt
+++ b/src/main/cpp/CMakeLists.txt
@@ -154,6 +154,7 @@ target_sources(log4cxx
locationinfo.cpp
locationinfofilter.cpp
logger.cpp
+ loggerrepository.cpp
loggermatchfilter.cpp
loggerpatternconverter.cpp
loggingevent.cpp
diff --git a/src/main/cpp/errorhandler.cpp b/src/main/cpp/errorhandler.cpp
index 4dbb47d8..ce997b78 100644
--- a/src/main/cpp/errorhandler.cpp
+++ b/src/main/cpp/errorhandler.cpp
@@ -19,6 +19,10 @@
using namespace LOG4CXX_NS;
using namespace LOG4CXX_NS::helpers;
+void spi::ErrorHandler::addAppenderHolder(const LogString&, const AppenderAttachablePtr&)
+{
+}
+
void spi::ErrorHandler::activateOptions( )
{
}
diff --git a/src/main/cpp/errorhandler.cpp b/src/main/cpp/loggerrepository.cpp
similarity index 75%
copy from src/main/cpp/errorhandler.cpp
copy to src/main/cpp/loggerrepository.cpp
index 4dbb47d8..e611c5e1 100644
--- a/src/main/cpp/errorhandler.cpp
+++ b/src/main/cpp/loggerrepository.cpp
@@ -14,11 +14,19 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-#include <log4cxx/spi/errorhandler.h>
+#include <log4cxx/spi/loggerrepository.h>
using namespace LOG4CXX_NS;
-using namespace LOG4CXX_NS::helpers;
+using namespace LOG4CXX_NS::spi;
-void spi::ErrorHandler::activateOptions( )
+LoggerRepository::~LoggerRepository()
+{
+}
+
+void LoggerRepository::fireAddAppenderEvent(const Logger*, const Appender*)
+{
+}
+
+void LoggerRepository::fireRemoveAppenderEvent(const Logger*, const Appender*)
{
}
diff --git a/src/main/include/log4cxx/spi/errorhandler.h b/src/main/include/log4cxx/spi/errorhandler.h
index a8620d47..082d5c99 100644
--- a/src/main/include/log4cxx/spi/errorhandler.h
+++ b/src/main/include/log4cxx/spi/errorhandler.h
@@ -72,7 +72,7 @@ class LOG4CXX_EXPORT ErrorHandler
@param name the collection name.
@param clx has a collection of appenders.
*/
- virtual void addAppenderHolder(const LogString& name, const AppenderAttachablePtr& clx) {};
+ virtual void addAppenderHolder(const LogString& name, const AppenderAttachablePtr& clx);
/**
Add a reference to a logger to which the failing appender might
diff --git a/src/main/include/log4cxx/spi/loggerrepository.h b/src/main/include/log4cxx/spi/loggerrepository.h
index f1f8a77e..2d2b9481 100644
--- a/src/main/include/log4cxx/spi/loggerrepository.h
+++ b/src/main/include/log4cxx/spi/loggerrepository.h
@@ -46,7 +46,7 @@ class LOG4CXX_EXPORT LoggerRepository : public virtual helpers::Object
BEGIN_LOG4CXX_CAST_MAP()
LOG4CXX_CAST_ENTRY(LoggerRepository)
END_LOG4CXX_CAST_MAP()
- virtual ~LoggerRepository() {}
+ virtual ~LoggerRepository();
/**
Add \c listener to the repository.
@@ -156,12 +156,12 @@ class LOG4CXX_EXPORT LoggerRepository : public virtual helpers::Object
/**
Call addAppenderEvent on all registered listeners.
*/
- virtual void fireAddAppenderEvent(const Logger* logger, const Appender* appender) {};
+ virtual void fireAddAppenderEvent(const Logger* logger, const Appender* appender);
/**
Call removeAppenderEvent on all registered listeners.
*/
- virtual void fireRemoveAppenderEvent(const Logger* logger, const Appender* appender) {};
+ virtual void fireRemoveAppenderEvent(const Logger* logger, const Appender* appender);
/**
Reset all values contained in this repository instance to their default.