You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/03 16:25:58 UTC
[GitHub] [flink] xintongsong commented on a change in pull request #10397:
[FLINK-15023][core][runtime] Remove on-heap managed memory
xintongsong commented on a change in pull request #10397: [FLINK-15023][core][runtime] Remove on-heap managed memory
URL: https://github.com/apache/flink/pull/10397#discussion_r353282724
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
##########
@@ -681,20 +677,16 @@ public void testManagedMemoryFractionForSpecifiedResourceSpec() throws Exception
final StreamConfig sourceConfig = new StreamConfig(vertex1.getConfiguration());
assertEquals(0.1, sourceConfig.getManagedMemoryFractionOnHeap(), 0.000001);
- assertEquals(0.4, sourceConfig.getManagedMemoryFractionOffHeap(), 0.000001);
Review comment:
Not really. We need this change because we have change the setting up part of this test cases, from setting both on-heap/off-heap managed memory in `ResourceSpec` to managed memory only. If we do not change the validation part, the test case will fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services