You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/03 11:38:32 UTC
[GitHub] [shardingsphere] xianzhuo-sky opened a new pull request #8496: Fixes #8431
xianzhuo-sky opened a new pull request #8496:
URL: https://github.com/apache/shardingsphere/pull/8496
Fixes #8431
Changes proposed in this pull request:
-Fixes NullPointerException Bug
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #8496: Fixes #8431
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #8496:
URL: https://github.com/apache/shardingsphere/pull/8496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #8496: Fixes #8431
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #8496:
URL: https://github.com/apache/shardingsphere/pull/8496#issuecomment-740352116
Hi @xianzhuo-sky Kindly ping here.
@terrymanu Could you give this PR a review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #8496: Fixes #8431
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #8496:
URL: https://github.com/apache/shardingsphere/pull/8496#issuecomment-745116019
No response
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8496: Fixes #8431
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8496:
URL: https://github.com/apache/shardingsphere/pull/8496#issuecomment-737910611
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8496?src=pr&el=h1) Report
> Merging [#8496](https://codecov.io/gh/apache/shardingsphere/pull/8496?src=pr&el=desc) (0f7c3f4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/31fb74fd516b5064b0ceb70e62be58bfd2c6945a?el=desc) (31fb74f) will **decrease** coverage by `0.64%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8496?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8496 +/- ##
============================================
- Coverage 73.46% 72.81% -0.65%
+ Complexity 603 602 -1
============================================
Files 1508 1533 +25
Lines 23905 24285 +380
Branches 4224 4272 +48
============================================
+ Hits 17561 17684 +123
- Misses 5184 5456 +272
+ Partials 1160 1145 -15
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8496?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../registry/ShardingSphereAlgorithmBeanRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1uYW1lc3BhY2UtaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9uYW1lc3BhY2UvcmVnaXN0cnkvU2hhcmRpbmdTcGhlcmVBbGdvcml0aG1CZWFuUmVnaXN0cnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...initializer/impl/StandardBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL1N0YW5kYXJkQm9vdHN0cmFwSW5pdGlhbGl6ZXIuamF2YQ==) | `66.66% <0.00%> (-33.34%)` | `1.00% <0.00%> (ø%)` | |
| [...hardingsphere/scaling/mysql/MySQLScalingEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMU2NhbGluZ0VudHJ5LmphdmE=) | `88.88% <0.00%> (-11.12%)` | `1.00% <0.00%> (ø%)` | |
| [...ere/scaling/postgresql/PostgreSQLScalingEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC9Qb3N0Z3JlU1FMU2NhbGluZ0VudHJ5LmphdmE=) | `88.88% <0.00%> (-11.12%)` | `1.00% <0.00%> (ø%)` | |
| [...ingsphere/governance/core/config/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2VudGVyLmphdmE=) | `66.43% <0.00%> (-9.57%)` | `0.00% <0.00%> (ø%)` | |
| [...ry/binary/execute/MySQLComStmtExecuteExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L2V4ZWN1dGUvTXlTUUxDb21TdG10RXhlY3V0ZUV4ZWN1dG9yLmphdmE=) | `70.00% <0.00%> (-7.78%)` | `0.00% <0.00%> (ø%)` | |
| [...infra/rule/builder/ShardingSphereRulesBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL2J1aWxkZXIvU2hhcmRpbmdTcGhlcmVSdWxlc0J1aWxkZXIuamF2YQ==) | `66.66% <0.00%> (-6.07%)` | `0.00% <0.00%> (ø%)` | |
| [...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh) | `88.23% <0.00%> (-5.52%)` | `0.00% <0.00%> (ø%)` | |
| [...itializer/impl/GovernanceBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL0dvdmVybmFuY2VCb290c3RyYXBJbml0aWFsaXplci5qYXZh) | `89.47% <0.00%> (-4.98%)` | `0.00% <0.00%> (ø%)` | |
| [...ext/fieldlist/MySQLComFieldListPacketExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9maWVsZGxpc3QvTXlTUUxDb21GaWVsZExpc3RQYWNrZXRFeGVjdXRvci5qYXZh) | `47.36% <0.00%> (-2.64%)` | `0.00% <0.00%> (ø%)` | |
| ... and [145 more](https://codecov.io/gh/apache/shardingsphere/pull/8496/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8496?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8496?src=pr&el=footer). Last update [31fb74f...0f7c3f4](https://codecov.io/gh/apache/shardingsphere/pull/8496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org