You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/08/23 00:50:58 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request, #1231: ORC-1212: Upgrade protobuf-java to 3.17.3

dongjoon-hyun opened a new pull request, #1231:
URL: https://github.com/apache/orc/pull/1231

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
     2. Use your PR title to summarize what this PR proposes instead of describing the problem.
     3. Make PR title and description complete because these will be the permanent commit log.
     4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
     5. If the PR is unfinished, use GitHub PR Draft feature.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3

Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on PR #1231:
URL: https://github.com/apache/orc/pull/1231#issuecomment-1225126915

   Upgrading protobuf-java without changing orc_proto.proto. The ORC binary is still backwards compatible & forward compatible, right?
   If I understand correctly, +1 LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1231:
URL: https://github.com/apache/orc/pull/1231#issuecomment-1225225530

   Thank you, @wgtmac and @guiyanakuang .  Yes, there is no change from our side.
   
   If there is any change, it could be inside `ProtocolBuffer` itself. Although we hesitate this upgrade until now in order to avoid any downstream burden, it seems that Apache ORC becomes the last one on `protobuf-java 2.5.0`. Since Apache ORC 1.7.x will still has `protobuf-java 2.5.0` until September 2024. I believe it's okay to have this in Apache ORC 1.8.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1231:
URL: https://github.com/apache/orc/pull/1231#issuecomment-1225226805

   Merged to main/1.8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1231:
URL: https://github.com/apache/orc/pull/1231#issuecomment-1224346097

   cc @guiyanakuang , @wgtmac , @stiga-huang , @pavibhai , too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1231:
URL: https://github.com/apache/orc/pull/1231#issuecomment-1223387244

   cc @williamhyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun closed pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3
URL: https://github.com/apache/orc/pull/1231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1231: ORC-1212: Upgrade `protobuf-java` to 3.17.3

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1231:
URL: https://github.com/apache/orc/pull/1231#issuecomment-1225312957

   To make this more safer, I created the following PR additionally, @wgtmac and @guiyanakuang .
   - https://github.com/apache/orc/pull/1233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org