You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/07 22:04:57 UTC

[GitHub] [incubator-tvm] jroesch opened a new pull request #6011: [Rust][CI] Move CI over to new Rust crates and try to fix flaky test.

jroesch opened a new pull request #6011:
URL: https://github.com/apache/incubator-tvm/pull/6011


   This PR finishes the move to the new Rust bindings and tries to integrate them into existing TVM docs and CI. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #6011: [Rust][CI] Move CI over to new Rust crates and try to fix flaky test.

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6011:
URL: https://github.com/apache/incubator-tvm/pull/6011


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6011: [Rust][CI] Move CI over to new Rust crates and try to fix flaky test.

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6011:
URL: https://github.com/apache/incubator-tvm/pull/6011#issuecomment-662211941


   THanks @jroesch @mwillsey , this PR is now merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] mwillsey commented on a change in pull request #6011: [Rust][CI] Move CI over to new Rust crates and try to fix flaky test.

Posted by GitBox <gi...@apache.org>.
mwillsey commented on a change in pull request #6011:
URL: https://github.com/apache/incubator-tvm/pull/6011#discussion_r457719724



##########
File path: rust/tvm-rt/src/to_boxed_fn.rs
##########
@@ -43,9 +43,8 @@ where
 {

Review comment:
       The whole `ToBoxedFn` seems a little strange. A trait called `To` should have function that takes `Self`, not return `Self`. It seems to be implemented backwards.
   
   Could you instead just have a generic, inherent method on `Function`? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] mwillsey commented on a change in pull request #6011: [Rust][CI] Move CI over to new Rust crates and try to fix flaky test.

Posted by GitBox <gi...@apache.org>.
mwillsey commented on a change in pull request #6011:
URL: https://github.com/apache/incubator-tvm/pull/6011#discussion_r457723748



##########
File path: rust/tvm-rt/src/to_boxed_fn.rs
##########
@@ -43,9 +43,8 @@ where
 {

Review comment:
       Ah nvm, this is unrelated to this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6011: [Rust][CI] Move CI over to new Rust crates and try to fix flaky test.

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6011:
URL: https://github.com/apache/incubator-tvm/pull/6011#issuecomment-655184574


   @jroesch can you comment out the flaky error first? since it is confirmed but was not fixed https://github.com/apache/incubator-tvm/issues/6009


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org