[GitHub] [arrow] CurtHagenlocher commented on a diff in pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest

["CurtHagenlocher (via GitHub)" <gi...@apache.org>]

CurtHagenlocher commented on code in PR #34989:
URL: https://github.com/apache/arrow/pull/34989#discussion_r1161168153


##########
csharp/src/Apache.Arrow/C/CArrowSchemaExporter.cs:
##########
@@ -86,8 +88,7 @@ public static unsafe void ExportField(Field field, CArrowSchema* schema)
         {
             ExportType(field.DataType, schema);
             schema->name = StringUtil.ToCStringUtf8(field.Name);
-            // TODO: field metadata
-            schema->metadata = null;
+            schema->metadata = field.HasMetadata ? ExportMetadata(field.Metadata) : null;

Review Comment:
   oops; hadn't meant to include these changes yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org