You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/10 03:44:01 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #12315: [client-tools] Optimize execution timing of jcommander.parse
yuruguo opened a new pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315
### Motivation
Do pre-judgment processing before calling `jcommander.parse` in CLI `pulsar-admin` / `pulsar-client`, including `version` command and `help` command
### Documentation
- no-need-doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-960823959
@codelipenghui @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939421027
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939492360
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939671330
> Could you add more context about this change? It seems that your pulsar-admin command didn't find the config file.
A [detailed description](https://github.com/apache/pulsar/pull/12315#issue-754626561) has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939415153
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower @hangc0276 please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-946239415
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939429461
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-943072873
> Did you move the configuration file? Then this exception occurs.
>
> ```
> ./bin/pulsar-admin topics list-partitioned-topics test/app1
> Exception in thread "main" java.io.FileNotFoundException: topics (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.<init>(FileInputStream.java:138)
> at java.io.FileInputStream.<init>(FileInputStream.java:93)
> at org.apache.pulsar.admin.cli.PulsarAdminTool.main(PulsarAdminTool.java:296)
> ```
you are right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-944855786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939418359
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939416279
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939671330
> Could you add more context about this change? It seems that your pulsar-admin command didn't find the config file.
A [detailed description](https://github.com/apache/pulsar/pull/12315#issue-754626561) has been added.
Please take a look for this PR, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-940561348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-945128181
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962739386
@hangc0276 @gaoran10 please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-960823959
@codelipenghui @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-946239415
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939680174
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [client-tools] Optimize execution timing of jcommander.parse
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939400717
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @hangc0276 please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939429461
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962293794
@hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939702157
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939495963
Could you add more context about this change? It seems that your pulsar-admin command didn't find the config file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-944855786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-947194279
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#discussion_r726728444
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
##########
@@ -285,11 +292,12 @@ boolean run(String[] args, Function<PulsarAdminBuilder, ? extends PulsarAdmin> a
public static void main(String[] args) throws Exception {
lastExitCode = 0;
- String configFile = null;
- if (args.length > 0) {
- configFile = args[0];
- args = Arrays.copyOfRange(args, 1, args.length);
+ if (args.length == 0) {
Review comment:
The `conf/client.conf` is not configured with `webServiceUrl` and `brokerServiceUrl` , as below:
```
# URL for Pulsar REST API (for admin operations)
# For TLS:
# webServiceUrl=https://localhost:8443/
# URL for Pulsar Binary Protocol (for produce and consume operations)
# For TLS:
# brokerServiceUrl=pulsar+ssl://localhost:6651/
```
and the `bin/pulsar-admin` does not specify `--admin-url`, as below:
```
./pulsar-admin topics list-partitioned-topics test/app1
```
then NPE will occur.
The root cause of this problem is that NPE appeared due to `serviceUrl==null` when PulsarAdminImpl was created, source code(PulsarAdminImpl.java#L191):
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L166-L168
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [client-tools] Optimize execution timing of jcommander.parse
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939402637
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-940561348
@merlimat @rdhabalia @aahmed-se @eolivelli @sijie @freeznet @yuruguo PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939680174
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939402637
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-950440244
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-947194279
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939482770
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939583800
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939702157
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939492360
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939482770
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-940561803
@merlimat @rdhabalia @aahmed-se @eolivelli @sijie @freeznet @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#discussion_r730341312
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
##########
@@ -285,11 +292,12 @@ boolean run(String[] args, Function<PulsarAdminBuilder, ? extends PulsarAdmin> a
public static void main(String[] args) throws Exception {
lastExitCode = 0;
- String configFile = null;
- if (args.length > 0) {
- configFile = args[0];
- args = Arrays.copyOfRange(args, 1, args.length);
+ if (args.length == 0) {
Review comment:
**About `file not found`**
https://github.com/apache/pulsar/pull/12315#issuecomment-943072873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-940561803
@merlimat @rdhabalia @aahmed-se @eolivelli @sijie @freeznet @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-943042814
Did you move the configuration file? Then this exception occurs.
```
./bin/pulsar-admin topics list-partitioned-topics test/app1
Exception in thread "main" java.io.FileNotFoundException: topics (No such file or directory)
at java.io.FileInputStream.open0(Native Method)
at java.io.FileInputStream.open(FileInputStream.java:195)
at java.io.FileInputStream.<init>(FileInputStream.java:138)
at java.io.FileInputStream.<init>(FileInputStream.java:93)
at org.apache.pulsar.admin.cli.PulsarAdminTool.main(PulsarAdminTool.java:296)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939416279
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939675619
@merlimat @rdhabalia @aahmed-se @eolivelli @sijie @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939415153
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower @hangc0276 please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939421027
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962739386
@hangc0276 @gaoran10 please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939671330
> Could you add more context about this change? It seems that your pulsar-admin command didn't find the config file.
A [detailed description](https://github.com/apache/pulsar/pull/12315#issue-1021870636) has been added.
Please take a look for this PR, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-945128181
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [client-tools] Optimize execution timing of jcommander.parse
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939400717
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @hangc0276 please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939418359
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939583800
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on a change in pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#discussion_r726680814
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
##########
@@ -285,11 +292,12 @@ boolean run(String[] args, Function<PulsarAdminBuilder, ? extends PulsarAdmin> a
public static void main(String[] args) throws Exception {
lastExitCode = 0;
- String configFile = null;
- if (args.length > 0) {
- configFile = args[0];
- args = Arrays.copyOfRange(args, 1, args.length);
+ if (args.length == 0) {
Review comment:
`bin/pulsar-admin` command will use `conf/client.conf` by default, and if you want to change the configuration file, you should define PULSAR_CLIENT_CONF. I doubt how the `null pointer exception` or `file not found exception` occurs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#discussion_r726728444
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
##########
@@ -285,11 +292,12 @@ boolean run(String[] args, Function<PulsarAdminBuilder, ? extends PulsarAdmin> a
public static void main(String[] args) throws Exception {
lastExitCode = 0;
- String configFile = null;
- if (args.length > 0) {
- configFile = args[0];
- args = Arrays.copyOfRange(args, 1, args.length);
+ if (args.length == 0) {
Review comment:
The `conf/client.conf` is not configured with `webServiceUrl` and `brokerServiceUrl` , as below:
```
# URL for Pulsar REST API (for admin operations)
# For TLS:
# webServiceUrl=https://localhost:8443/
# URL for Pulsar Binary Protocol (for produce and consume operations)
# For TLS:
# brokerServiceUrl=pulsar+ssl://localhost:6651/
```
and the `bin/pulsar-admin` does not specify `--admin-url`, as below:
```
./pulsar-admin topics list-partitioned-topics test/app1
```
then NPE will occur.
The root cause of this problem is that NPE appeared due to `serviceUrl==null` when PulsarAdminImpl was created, source code:
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L166-L168
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-939675619
@merlimat @rdhabalia @eolivelli @sijie @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-950440244
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962293794
@hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#discussion_r726728444
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
##########
@@ -285,11 +292,12 @@ boolean run(String[] args, Function<PulsarAdminBuilder, ? extends PulsarAdmin> a
public static void main(String[] args) throws Exception {
lastExitCode = 0;
- String configFile = null;
- if (args.length > 0) {
- configFile = args[0];
- args = Arrays.copyOfRange(args, 1, args.length);
+ if (args.length == 0) {
Review comment:
**About NPE:**
The `conf/client.conf` is not configured with `webServiceUrl` and `brokerServiceUrl` , as below:
```
# URL for Pulsar REST API (for admin operations)
# For TLS:
# webServiceUrl=https://localhost:8443/
# URL for Pulsar Binary Protocol (for produce and consume operations)
# For TLS:
# brokerServiceUrl=pulsar+ssl://localhost:6651/
```
and the `bin/pulsar-admin` does not specify `--admin-url`, as below:
```
./pulsar-admin topics list-partitioned-topics test/app1
```
then NPE will occur.
The root cause of this problem is that NPE appeared due to `serviceUrl==null` when PulsarAdminImpl was created, source code(PulsarAdminImpl.java#L191):
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L166-L168
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#discussion_r726728444
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
##########
@@ -285,11 +292,12 @@ boolean run(String[] args, Function<PulsarAdminBuilder, ? extends PulsarAdmin> a
public static void main(String[] args) throws Exception {
lastExitCode = 0;
- String configFile = null;
- if (args.length > 0) {
- configFile = args[0];
- args = Arrays.copyOfRange(args, 1, args.length);
+ if (args.length == 0) {
Review comment:
**About `NPE`**
The `conf/client.conf` is not configured with `webServiceUrl` and `brokerServiceUrl` , as below:
```
# URL for Pulsar REST API (for admin operations)
# For TLS:
# webServiceUrl=https://localhost:8443/
# URL for Pulsar Binary Protocol (for produce and consume operations)
# For TLS:
# brokerServiceUrl=pulsar+ssl://localhost:6651/
```
and the `bin/pulsar-admin` does not specify `--admin-url`, as below:
```
./pulsar-admin topics list-partitioned-topics test/app1
```
then NPE will occur.
The root cause of this problem is that NPE appeared due to `serviceUrl==null` when PulsarAdminImpl was created, source code(PulsarAdminImpl.java#L191):
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L166-L168
https://github.com/apache/pulsar/blob/8505422b784e1d89db68a0196a93229609c10903/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java#L191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-944892121
@eolivelli @aahmed-se @eolivelli @k2la @codelipenghui @congbobo184 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org