1.5.6 not C Standard 1989 compliant

[Dan Poirier <po...@pobox.com>]

I happen to be trying to compile svn 1.5.6 with a compiler that
supports C89 but not C99, and have run into a number of instances
of code that isn't valid under C89 - mostly non-constant struct
initializations, and one trailing comma.
The developer's guidelines at
http://subversion.tigris.org/hacking.html#coding-style say that
subversion uses ANSI C, but doesn't specify which standard.
I haven't tried the 1.6.0 release candidates.
Should subversion be C89 compliant?  Or is it intending to use
C99-only constructs?
Thanks,
Dan

Re: 1.5.6 not C Standard 1989 compliant

["Hyrum K. Wright" <hy...@mail.utexas.edu>]

On Mar 17, 2009, at 8:06 AM, Dan Poirier wrote:

> I happen to be trying to compile svn 1.5.6 with a compiler that  
> supports C89 but not C99, and have run into a number of instances of  
> code that isn't valid under C89 - mostly non-constant struct  
> initializations, and one trailing comma.
>
> The developer's guidelines at http://subversion.tigris.org/hacking.html#coding-style 
>  say that subversion uses ANSI C, but doesn't specify which standard.
>
> I haven't tried the 1.6.0 release candidates.
>
> Should subversion be C89 compliant?  Or is it intending to use C99- 
> only constructs?

It's supposed to be C89 compliant, and most of the developers try to  
compile with the appropriate flags to catch such.  However, due to  
various conditional compilation scenarios, some may be missed.

Could you see if you are having the same errors on Subversion trunk,  
and if so, would it be possible to post a patch to dev@ fixing the  
problems you found?

Thanks,
-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=1341122

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].