You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by "Shubham Sharma (JIRA)" <ji...@apache.org> on 2017/06/11 01:45:20 UTC

[jira] [Commented] (HAWQ-1373) command name to reload hawq config (hawq stop cluster -u) is misleading

    [ https://issues.apache.org/jira/browse/HAWQ-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045777#comment-16045777 ] 

Shubham Sharma commented on HAWQ-1373:
--------------------------------------

[~lisakowen] [~espino] I would like to submit a PR for this improvement. I have scoped out some changes, below is a quick summary. I have tried to keep the changes least intrusive from the code perspective. The below snippet will let ,"hawq reload-config <object> -<sub_arguments>", call "hawq stop <object> -u -<sub_arguments>" internally. This should provide a neat facade to the end user.

Code changes - 
incubator-hawq/tools/bin/hawq
Add the below code section
{code}
    elif hawq_command == "reload-config”: //reload-config internally setting up a call for hawk stop <object> -u
        hawq_command="stop"
        sub_args_list.append("-u")
        sub_args=" ".join(sub_args_list)
        if second_arg not in cluster_type_list:
            print STOP_HELP
            sys.exit(1)
        cmd = "%s; hawq_ctl %s %s" % (source_hawq_env, hawq_command, sub_args)
        result = local_run(cmd)
 {code}

Documentation modifications - 

- tools/bin/hawqpylib/HAWQ_HELP.py
- https://github.com/apache/incubator-hawq-docs/search?utf8=%E2%9C%93&q=%22hawq+stop+cluster+-u%22&type=
- https://github.com/apache/incubator-hawq-docs/search?utf8=%E2%9C%93&q=%22hawq+stop+cluster+--reload%22&type=
- https://github.com/apache/incubator-hawq-docs/search?utf8=%E2%9C%93&q=%22hawq+stop+master+-u%22&type=
- https://github.com/apache/incubator-hawq-docs/search?p=3&q=reload+&type=&utf8=%E2%9C%93

Also, have tested these changes in my local setup and they seem to work. Is there anything else that needs to be addressed here ?

> command name to reload hawq config (hawq stop cluster -u) is misleading
> -----------------------------------------------------------------------
>
>                 Key: HAWQ-1373
>                 URL: https://issues.apache.org/jira/browse/HAWQ-1373
>             Project: Apache HAWQ
>          Issue Type: Improvement
>          Components: Command Line Tools
>            Reporter: Lisa Owen
>            Assignee: Ed Espino
>            Priority: Minor
>
> one must run "hawq stop cluster -u" or "hawq stop cluster --reload" to update hawq configuration parameters without a cluster restart.  the name/format of this command is kind of misleading.  can we consider changing it to "hawq reload-config cluster" or something that better describes the operation?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)