You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/12/30 20:48:27 UTC
[GitHub] [cordova-lib] purplecabbage opened a new pull request, #905: CI runs on 14,16,18
purplecabbage opened a new pull request, #905:
URL: https://github.com/apache/cordova-lib/pull/905
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] purplecabbage commented on a diff in pull request #905: ci(workflow): update codecov action usage
Posted by GitBox <gi...@apache.org>.
purplecabbage commented on code in PR #905:
URL: https://github.com/apache/cordova-lib/pull/905#discussion_r1066017161
##########
.github/workflows/ci.yml:
##########
@@ -46,6 +46,8 @@ jobs:
env:
CI: true
- - uses: codecov/codecov-action@v3
+ - name: upload coverage
+ if: success()
+ uses: codecov/codecov-action@v3.1.1
with:
- fail_ci_if_error: true
+ name: ${{ runner.os }} node.js ${{ matrix.node-version }}
Review Comment:
The name just changes what is displayed from 'Run codecov/codecov-action@v3' to 'upload coverage'. This is just a preference to me, not vital.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] codecov-commenter commented on pull request #905: CI runs on 14,16,18
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #905:
URL: https://github.com/apache/cordova-lib/pull/905#issuecomment-1368086665
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/905?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#905](https://codecov.io/gh/apache/cordova-lib/pull/905?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ae50a2) into [master](https://codecov.io/gh/apache/cordova-lib/commit/d2e9c53945a9911ba003c624ea8068a3733ec56e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d2e9c53) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #905 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 46 46
Lines 2123 2123
=======================================
Hits 1872 1872
Misses 251 251
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] erisu commented on a diff in pull request #905: ci: update node support to 14,16,18
Posted by GitBox <gi...@apache.org>.
erisu commented on code in PR #905:
URL: https://github.com/apache/cordova-lib/pull/905#discussion_r1065927083
##########
.github/workflows/ci.yml:
##########
@@ -46,6 +46,8 @@ jobs:
env:
CI: true
- - uses: codecov/codecov-action@v3
+ - name: upload coverage
+ if: success()
+ uses: codecov/codecov-action@v3.1.1
with:
- fail_ci_if_error: true
+ name: ${{ runner.os }} node.js ${{ matrix.node-version }}
Review Comment:
Would it be better written this way?
```yaml
- uses: codecov/codecov-action@v3
if: success()
with:
name: ${{ runner.os }} node.js ${{ matrix.node-version }}
```
I dont think the first `name` field is required as we are not appending any unique values to the field.
I feel the default name is efficient. Example: `Run codecov/codecov-action@v3`
Also, do you want to use `codecov/codecov-action@v3` or `codecov/codecov-action@v3.1.1`?
* `v3` always fetch the latetst released version of `3.x`.
* `v3.1.1` will always be locked in at the same version and not fetch any fixes. If anything breaks, we will have to update manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] erisu merged pull request #905: ci(workflow): update codecov action usage
Posted by GitBox <gi...@apache.org>.
erisu merged PR #905:
URL: https://github.com/apache/cordova-lib/pull/905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org