You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "a601942905git (GitHub)" <gi...@apache.org> on 2018/10/30 05:59:21 UTC

[GitHub] [incubator-dubbo-website] a601942905git opened pull request #168: update closed label error auout group-merger in dubbo doc

## What is the purpose of the change

to fix the[apache/incubator-dubbo-website#165](https://github.com/apache/incubator-dubbo-website/issues/165)issues

## Brief changelog
- before fixed
```
<dubbo:reference interface="com.xxx.MenuService" group="*">
    <dubbo:method name="getMenuItems" merger="true" />
</dubbo:service>

<dubbo:reference interface="com.xxx.MenuService" group="*" merger="true">
    <dubbo:method name="getMenuItems" merger="false" />
</dubbo:service>

<dubbo:reference interface="com.xxx.MenuService" group="*">
    <dubbo:method name="getMenuItems" merger="mymerge" />
</dubbo:service>

<dubbo:reference interface="com.xxx.MenuService" group="*">
    <dubbo:method name="getMenuItems" merger=".addAll" />
</dubbo:service>
```
- after fixed
```
<dubbo:reference interface="com.xxx.MenuService" group="*">
    <dubbo:method name="getMenuItems" merger="true" />
</dubbo:reference>

<dubbo:reference interface="com.xxx.MenuService" group="*" merger="true">
    <dubbo:method name="getMenuItems" merger="false" />
</dubbo:reference>

<dubbo:reference interface="com.xxx.MenuService" group="*">
    <dubbo:method name="getMenuItems" merger="mymerge" />
</dubbo:reference>

<dubbo:reference interface="com.xxx.MenuService" group="*">
    <dubbo:method name="getMenuItems" merger=".addAll" />
</dubbo:reference>
```


Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo-website/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Test your code locally by running `docsite start`, and make sure it works as expected.
- [ ] Make sure no files under build directory is added.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/168 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo-website] diecui1202 commented on issue #168: update closed label error auout group-merger in dubbo doc

Posted by "diecui1202 (GitHub)" <gi...@apache.org>.
@a601942905git Thanks for your contribution.

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/168 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo-website] a601942905git commented on issue #168: update closed label error auout group-merger in dubbo doc

Posted by "a601942905git (GitHub)" <gi...@apache.org>.
it is my pleasure

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/168 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo-website] diecui1202 closed pull request #168: update closed label error auout group-merger in dubbo doc

Posted by "diecui1202 (GitHub)" <gi...@apache.org>.
[ pull request closed by diecui1202 ]

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/168 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org