You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/10/31 17:14:31 UTC

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1282: IGNITE-17899 Properly stopping resources in TableManager.

tkalkirill commented on code in PR #1282:
URL: https://github.com/apache/ignite-3/pull/1282#discussion_r1009667020


##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java:
##########
@@ -36,7 +36,7 @@
 /**
  * Table storage that contains meta, partitions and SQL indexes.
  */
-public interface MvTableStorage {
+public interface MvTableStorage extends AutoCloseable {

Review Comment:
   Can method `close()` be defined explicitly?
   This will get rid of warnings on the idea that we don't close the resource after it's been used.
   @sanpwc wdyt



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org