You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/01/05 09:47:27 UTC
Re: Review Request 71941: RANGER-2680 : Ranger Usersync and Tagsync
is not updating session cookie until restart
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71941/#review219124
-----------------------------------------------------------
Fix it, then Ship it!
tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java
Lines 325 (patched)
<https://reviews.apache.org/r/71941/#comment307223>
Name of the session cookie can be customized in Ranger admin - via web.xml:session-config.cookie-config.name. I suggest to replace the hardcoded value in #325 and #281 with value read from configuration (like ranger.tagsync.dest.ranger.session.cookie.name).
- Madhan Neethiraj
On Dec. 27, 2019, 7:32 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71941/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2019, 7:32 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2680
> https://issues.apache.org/jira/browse/RANGER-2680
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger Usersync and Tagsync is not updating session cookie until restart, this is generating unnecessary login sessions in ranger admin from usersync and tagsync.
>
>
>
> Ranger clients should update the invalid session cookie and replace it with cookie which is valid and avoid unnecessary login session count increment.
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java dff7241ca
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java b6a29878d
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 6a24213ef
>
>
> Diff: https://reviews.apache.org/r/71941/diff/1/
>
>
> Testing
> -------
>
> 1.Dev tested on local VM
>
>
> Thanks,
>
> Nikhil P
>
>