You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/12 19:30:00 UTC
[jira] [Commented] (AVRO-2256) Error checking compatibility of
record reader schema with union writer schema
[ https://issues.apache.org/jira/browse/AVRO-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684284#comment-16684284 ]
ASF GitHub Bot commented on AVRO-2256:
--------------------------------------
Fokko commented on a change in pull request #368: AVRO-2256 Prevent error checking compatibility of a record reading a union in Ruby
URL: https://github.com/apache/avro/pull/368#discussion_r232784016
##########
File path: lang/ruby/lib/avro/schema_compatibility.rb
##########
@@ -141,6 +141,8 @@ def match_union_schemas(writers_schema, readers_schema)
end
def match_record_schemas(writers_schema, readers_schema)
+ return false if writers_schema.type_sym == :union
Review comment:
Haven't done Ruby for a while. This will return always `false` when it is a union?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Error checking compatibility of record reader schema with union writer schema
> -----------------------------------------------------------------------------
>
> Key: AVRO-2256
> URL: https://issues.apache.org/jira/browse/AVRO-2256
> Project: Apache Avro
> Issue Type: Bug
> Components: ruby
> Affects Versions: 1.9.0
> Reporter: Tim Perkins
> Assignee: Tim Perkins
> Priority: Critical
> Fix For: 1.9.0
>
>
> This raises a missing method error because the comparison is invalid.
> Fix: https://github.com/apache/avro/pull/368
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)