You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/17 18:28:01 UTC
[GitHub] [maven-resolver] michael-o commented on a change in pull request #140: [MRESOLVER-231] Extend smart checksum support
michael-o commented on a change in pull request #140:
URL: https://github.com/apache/maven-resolver/pull/140#discussion_r771604768
##########
File path: src/site/markdown/smart-checksum-strategies.md
##########
@@ -0,0 +1,56 @@
+# Smart Checksum Strategies
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+By default, Resolver will fetch the payload checksum from remote repository. These
+checksums are used to enforce transport validity (that download is not corrupted).
+
+This implies, that to get one artifact, resolver needs to issue two HTTP reuest:
+one to get the artifact itself, and one to get the checksum.
+
+By using "smart checksums" feature, we are able to half the issued HTTP request
+count, as many services and Maven Central emit the reference checksums in
+the artifact response itself, as HTTP Headers, so we are able to get the
+artifact and it's checksum in only one request.
Review comment:
its, possive pronoun, not a contraction of it and is
##########
File path: src/site/markdown/smart-checksum-strategies.md
##########
@@ -0,0 +1,56 @@
+# Smart Checksum Strategies
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+By default, Resolver will fetch the payload checksum from remote repository. These
+checksums are used to enforce transport validity (that download is not corrupted).
+
+This implies, that to get one artifact, resolver needs to issue two HTTP reuest:
Review comment:
Not only artifact, applies to all, artifact, poms, metadata.
##########
File path: src/site/markdown/smart-checksum-strategies.md
##########
@@ -0,0 +1,56 @@
+# Smart Checksum Strategies
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+By default, Resolver will fetch the payload checksum from remote repository. These
+checksums are used to enforce transport validity (that download is not corrupted).
+
+This implies, that to get one artifact, resolver needs to issue two HTTP reuest:
Review comment:
request
##########
File path: src/site/markdown/smart-checksum-strategies.md
##########
@@ -0,0 +1,56 @@
+# Smart Checksum Strategies
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+By default, Resolver will fetch the payload checksum from remote repository. These
+checksums are used to enforce transport validity (that download is not corrupted).
+
+This implies, that to get one artifact, resolver needs to issue two HTTP reuest:
+one to get the artifact itself, and one to get the checksum.
+
+By using "smart checksums" feature, we are able to half the issued HTTP request
+count, as many services and Maven Central emit the reference checksums in
+the artifact response itself, as HTTP Headers, so we are able to get the
+artifact and it's checksum in only one request.
+
+
+## Sonatype Nexus2
Review comment:
Nexus 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org