[jira] [Commented] (HBASE-13362) set max result size from client only (like caching)?

["Lars Hofhansl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391446#comment-14391446 ] 

Lars Hofhansl commented on HBASE-13362:
---------------------------------------

Agreed (I stated the safety max setting on the server somewhere - in some jira, but apparently not here).

Would need to be another config option, then. Could have the server setting be in % of the heap, or maybe that's too complicated and we invent a new setting hbase.server.scanner.max.result.size and default that 100mb or so (nobody in their right mind would set the client side setting that high anyway).

Now, that would not be 100% backwards compatible? OK to change in 0.98/1.0.x? I'd also lean against setting caching to Long.MAX_VALUE in 0.98/1.0.x. That would be confusing, I think.

> set max result size from client only (like caching)?
> ----------------------------------------------------
>
>                 Key: HBASE-13362
>                 URL: https://issues.apache.org/jira/browse/HBASE-13362
>             Project: HBase
>          Issue Type: Brainstorming
>            Reporter: Lars Hofhansl
>
> With the recent problems we've been seeing client/server result size mismatch, I was thinking: Why was this not a problem with scanner caching?
> There are two reasons:
> # number of rows is easy to calculate (and we did it correctly)
> # caching is only controlled from the client, never set on the server alone
> We did fix both #1 and #2 in HBASE-13262.
> Still, I'd like to discuss the following:
> * default the client sent max result size to 2mb
> * remove any server only result sizing
> * continue to use hbase.client.scanner.max.result.size but enforce it via the client only (as the name implies anyway).
> Comments? Concerns?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)