You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/17 10:58:10 UTC

[GitHub] [skywalking] xuanyu66 opened a new issue #6566: no trace id in async log

xuanyu66 opened a new issue #6566:
URL: https://github.com/apache/skywalking/issues/6566


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [X] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Bug
   - Which version of SkyWalking, OS, and JRE?
   SkyWalking:8.4.0
   plugin:apm-toolkit-log4j-2.x-activation
   
   - What happened?
   Method createMemento() in class LogEvent will produce  a new immutable copy of Log4jLogEvent.
   But deserialization and then serialization will make Log4jLogEvent lose SkyWalkingDynamicField, which cause no trace id in log
   ```
   org.apache.logging.log4j.core.impl.LogEvent
   
       /**
        * Creates and returns a new immutable copy of this {@code Log4jLogEvent}.
        *
        * @return a new immutable copy of the data in this {@code Log4jLogEvent}
        */
       public static Log4jLogEvent createMemento(final LogEvent event, final boolean includeLocation) {
           // TODO implement Log4jLogEvent.createMemento()
           return deserialize(serialize(event, includeLocation));
       }
   
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #6566: no trace id in async log

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6566:
URL: https://github.com/apache/skywalking/issues/6566


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org