You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by TJ-Cutajar <gi...@git.apache.org> on 2014/06/08 16:40:58 UTC
[GitHub] httpclient pull request: Added the ability to cache responses to H...
GitHub user TJ-Cutajar opened a pull request:
https://github.com/apache/httpclient/pull/13
Added the ability to cache responses to HEAD requests
A subsequent GET request to the same URI will result in a call to origin. A cache entry that exists from a previous GET can be used to satisfy a HEAD request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TJ-Cutajar/httpclient cache-head-responses
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 238bae0ff77ac1419a95b51f8152875ff45c1f12
Author: Tyrone Cutajar <tj...@gmail.com>
Date: 2014-06-08T14:25:20Z
Added the ability to cache responses to HEAD requests. Subsequent GET requests to the same URI result in a call to origin. A cache entry that exists from a previous GET can be used to satisfy a HEAD request.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [GitHub] httpclient pull request: Added the ability to cache
responses to H...
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Mon, 2014-06-09 at 11:13 -0400, Jon Moore wrote:
> What's the established mechanism for handling pull requests on the Github
> mirror of the project? For example, I have commentary on the PR below but
> am not sure whether I should comment on the PR itself or if I should
> redirect the contributor to the official JIRA / patchset process. I
> couldn't find this described on our website or wiki anywhere.
>
> Thanks,
> Jon
>
Hi Jon
Based purely on my personal interpretation of this blog [1] it should be
perfectly OK to comment on the PR at GitHub. However, for substantial
contributions like this one a JIRA should still be raised and linked
with the PR at GitHub
Oleg
[1]
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
> On Sun, Jun 8, 2014 at 10:40 AM, TJ-Cutajar <gi...@git.apache.org> wrote:
>
> > GitHub user TJ-Cutajar opened a pull request:
> >
> > https://github.com/apache/httpclient/pull/13
> >
> > Added the ability to cache responses to HEAD requests
> >
> > A subsequent GET request to the same URI will result in a call to
> > origin. A cache entry that exists from a previous GET can be used to
> > satisfy a HEAD request.
> >
> > You can merge this pull request into a Git repository by running:
> >
> > $ git pull https://github.com/TJ-Cutajar/httpclient
> > cache-head-responses
> >
> > Alternatively you can review and apply these changes as the patch at:
> >
> > https://github.com/apache/httpclient/pull/13.patch
> >
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> > This closes #13
> >
> > ----
> > commit 238bae0ff77ac1419a95b51f8152875ff45c1f12
> > Author: Tyrone Cutajar <tj...@gmail.com>
> > Date: 2014-06-08T14:25:20Z
> >
> > Added the ability to cache responses to HEAD requests. Subsequent GET
> > requests to the same URI result in a call to origin. A cache entry that
> > exists from a previous GET can be used to satisfy a HEAD request.
> >
> > ----
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have your
> > reply appear on GitHub as well. If your project does not have this feature
> > enabled and wishes so, or if the feature is enabled but not working, please
> > contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> > with INFRA.
> > ---
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [GitHub] httpclient pull request: Added the ability to cache
responses to H...
Posted by Jon Moore <jo...@apache.org>.
What's the established mechanism for handling pull requests on the Github
mirror of the project? For example, I have commentary on the PR below but
am not sure whether I should comment on the PR itself or if I should
redirect the contributor to the official JIRA / patchset process. I
couldn't find this described on our website or wiki anywhere.
Thanks,
Jon
On Sun, Jun 8, 2014 at 10:40 AM, TJ-Cutajar <gi...@git.apache.org> wrote:
> GitHub user TJ-Cutajar opened a pull request:
>
> https://github.com/apache/httpclient/pull/13
>
> Added the ability to cache responses to HEAD requests
>
> A subsequent GET request to the same URI will result in a call to
> origin. A cache entry that exists from a previous GET can be used to
> satisfy a HEAD request.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/TJ-Cutajar/httpclient
> cache-head-responses
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/httpclient/pull/13.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #13
>
> ----
> commit 238bae0ff77ac1419a95b51f8152875ff45c1f12
> Author: Tyrone Cutajar <tj...@gmail.com>
> Date: 2014-06-08T14:25:20Z
>
> Added the ability to cache responses to HEAD requests. Subsequent GET
> requests to the same URI result in a call to origin. A cache entry that
> exists from a previous GET can be used to satisfy a HEAD request.
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
[GitHub] httpclient pull request: Added the ability to cache responses to H...
Posted by fxbonnet <gi...@git.apache.org>.
Github user fxbonnet commented on the pull request:
https://github.com/apache/httpclient/pull/13#issuecomment-93666814
Can someone close this pull request? The changes have been merged and the JIRA is closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request: Added the ability to cache responses to H...
Posted by TJ-Cutajar <gi...@git.apache.org>.
Github user TJ-Cutajar closed the pull request at:
https://github.com/apache/httpclient/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request: Added the ability to cache responses to H...
Posted by TJ-Cutajar <gi...@git.apache.org>.
Github user TJ-Cutajar commented on the pull request:
https://github.com/apache/httpclient/pull/13#issuecomment-45532766
Hi there,
I've raised JIRA 1515 with a link to this PR.
Thanks,
Tyrone
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org