You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/02 14:33:58 UTC

[GitHub] TaoLv commented on a change in pull request #13088: make ROIAlign support position-sensitive pooling

TaoLv commented on a change in pull request #13088: make ROIAlign support position-sensitive pooling
URL: https://github.com/apache/incubator-mxnet/pull/13088#discussion_r244747304
 
 

 ##########
 File path: src/operator/contrib/roi_align.cc
 ##########
 @@ -156,7 +157,10 @@ void ROIAlignForward(
   int n_rois = nthreads / channels / pooled_width / pooled_height;
   // (n, c, ph, pw) is an element in the pooled output
   // can be parallelized using omp
-  for (int n = 0; n < n_rois; n++) {
+  int n;
 
 Review comment:
   Is it possible to move this definition into the for-loop?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services