You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "KSPT-taylorjohn (via GitHub)" <gi...@apache.org> on 2023/08/31 17:39:27 UTC
[GitHub] [superset] KSPT-taylorjohn opened a new pull request, #25150: fix: Chart series limit doesn't work for some databases
KSPT-taylorjohn opened a new pull request, #25150:
URL: https://github.com/apache/superset/pull/25150
Fix for series limit subquery creation for databases that mutate labels.
Fixes #25073
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #25150:
URL: https://github.com/apache/superset/pull/25150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] KSPT-taylorjohn commented on pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "KSPT-taylorjohn (via GitHub)" <gi...@apache.org>.
KSPT-taylorjohn commented on PR #25150:
URL: https://github.com/apache/superset/pull/25150#issuecomment-1701779775
@villebro Sorry I have fixed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] KSPT-taylorjohn commented on pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "KSPT-taylorjohn (via GitHub)" <gi...@apache.org>.
KSPT-taylorjohn commented on PR #25150:
URL: https://github.com/apache/superset/pull/25150#issuecomment-1701507646
Please review @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #25150:
URL: https://github.com/apache/superset/pull/25150#issuecomment-1701845273
@eschutho @michael-s-molina this PR would be great to get into the next patch release of 3.0 and 2.1 (if we're still doing one more for 2.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #25150:
URL: https://github.com/apache/superset/pull/25150#issuecomment-1701846608
Thanks! I just tagged it for 2.1.2 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #25150:
URL: https://github.com/apache/superset/pull/25150#issuecomment-1702576487
> @eschutho @michael-s-molina this PR would be great to get into the next patch release of 3.0 and 2.1 (if we're still doing one more for 2.1)
I'll cherry-pick it for 3.0 given that we're still working on RC4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #25150:
URL: https://github.com/apache/superset/pull/25150#issuecomment-1701732662
@KSPT-taylorjohn there's a lint issue:
```patch
diff --git a/superset/models/helpers.py b/superset/models/helpers.py
index 810de46372..6ae1e4d0a0 100644
--- a/superset/models/helpers.py
+++ b/superset/models/helpers.py
@@ -102,7 +102,6 @@ SERIES_LIMIT_SUBQ_ALIAS = "series_limit"
ADVANCED_DATA_TYPES = config["ADVANCED_DATA_TYPES"]
-
def validate_adhoc_subquery(
sql: str,
database_id: int,
@@ -1470,7 +1469,7 @@ class ExploreMixin: # pylint: disable=too-many-public-methods
db_engine_spec.make_label_compatible(column)
for column in utils.get_column_names(
columns=series_columns or [],
- )
+ )
]
# deprecated, to be removed in 2.0
if is_timeseries and timeseries_limit:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #25150: fix: Chart series limit doesn't work for some databases
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #25150:
URL: https://github.com/apache/superset/pull/25150#issuecomment-1701855986
FYI @genzgd if someone complains about series limits not working in Superset using Clickhouse Connect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org