You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/11 05:56:03 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4488: Fix
NoSuchElement exception for lazy injection.
wu-sheng opened a new pull request #4488: Fix NoSuchElement exception for lazy injection.
URL: https://github.com/apache/skywalking/pull/4488
According to https://github.com/apache/skywalking/pull/4441#issuecomment-597453559, my previous implementation of lazy injection faces an issue.
If the main thread tracing has been finished, the exit span could still be in async mode, and do `#inject`, this error will show up.
@huangyoje Please give this a try, should be able to fix your issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] huangyoje commented on issue #4488: Fix NoSuchElement
exception for lazy injection.
Posted by GitBox <gi...@apache.org>.
huangyoje commented on issue #4488: Fix NoSuchElement exception for lazy injection.
URL: https://github.com/apache/skywalking/pull/4488#issuecomment-597467917
@wu-sheng I have tested and this fixed my issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] huangyoje commented on issue #4488: Fix NoSuchElement
exception for lazy injection.
Posted by GitBox <gi...@apache.org>.
huangyoje commented on issue #4488: Fix NoSuchElement exception for lazy injection.
URL: https://github.com/apache/skywalking/pull/4488#issuecomment-597460216
@wu-sheng OK, I will try soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4488: Fix NoSuchElement
exception for lazy injection.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4488: Fix NoSuchElement exception for lazy injection.
URL: https://github.com/apache/skywalking/pull/4488#issuecomment-597468319
Thanks. I am waiting for another commit to approve this PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4488: Fix NoSuchElement
exception for lazy injection.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4488: Fix NoSuchElement exception for lazy injection.
URL: https://github.com/apache/skywalking/pull/4488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services