You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "liujiayi771 (via GitHub)" <gi...@apache.org> on 2024/03/21 06:43:48 UTC
[PR] [VL] Download boost source code directly [incubator-gluten]
liujiayi771 opened a new pull request, #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071
## What changes were proposed in this pull request?
CI test take a lot of time to git clone boost source code. We could consider directly downloading the source code, similar to what setup-centos8.sh does.
## How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Replace "git clone" by downloading tar package for boost in setup-ubuntu.sh [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Download boost source code directly [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2011323187
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2011694284
cc @PHILO-HE @zhouyuan, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2011689252
It took about 11 min before (from 2024-03-21T06:20:47 to 2024-03-21T06:31:13):
```
2024-03-21T06:20:47.3262778Z + run_and_time install_boost
2024-03-21T06:20:47.3263537Z + install_boost
2024-03-21T06:20:47.3264743Z + github_checkout boostorg/boost boost-1.84.0 --recursive
2024-03-21T06:20:47.3271539Z + local REPO=boostorg/boost
2024-03-21T06:20:47.3272490Z + shift
2024-03-21T06:20:47.3273275Z + local VERSION=boost-1.84.0
2024-03-21T06:20:47.3274005Z + shift
2024-03-21T06:20:47.3274716Z + local GIT_CLONE_PARAMS=--recursive
2024-03-21T06:20:47.3275628Z ++ basename boostorg/boost
2024-03-21T06:20:47.3276434Z + Finished running install_fmt
2024-03-21T06:20:47.3277281Z + local DIRNAME=boost
2024-03-21T06:20:47.3278123Z + SUDO='sudo --preserve-env'
2024-03-21T06:20:47.3279167Z + cd /opt/gluten/ep/build-velox/build/velox_ep
2024-03-21T06:20:47.3280153Z + '[' -z boost ']'
2024-03-21T06:20:47.3281462Z + '[' -d boost ']'
2024-03-21T06:20:47.3282170Z + '[' '!' -d boost ']'
2024-03-21T06:20:47.3283545Z + git clone -q -b boost-1.84.0 --recursive https://github.com/boostorg/boost.git
2024-03-21T06:21:00.5554970Z Note: switching to 'ad09f667e61e18f5c31590941e748ac38e5a81bf'.
2024-03-21T06:21:00.5556728Z
2024-03-21T06:21:00.5557598Z You are in 'detached HEAD' state. You can look around, make experimental
2024-03-21T06:21:00.5559211Z changes and commit them, and you can discard any commits you make in this
2024-03-21T06:21:00.5560889Z state without impacting any branches by switching back to a branch.
2024-03-21T06:21:00.5561865Z
2024-03-21T06:21:00.5562552Z If you want to create a new branch to retain commits you create, you may
2024-03-21T06:21:00.5564281Z do so (now or later) by using -c with the switch command. Example:
2024-03-21T06:21:00.5565210Z
2024-03-21T06:21:00.5565585Z git switch -c <new-branch-name>
2024-03-21T06:21:00.5667647Z
2024-03-21T06:21:00.5668525Z Or undo this operation with:
2024-03-21T06:21:00.5669179Z
2024-03-21T06:21:00.5669430Z git switch -
2024-03-21T06:21:00.5788570Z
2024-03-21T06:21:00.5869925Z Turn off this advice by setting config variable advice.detachedHead to false
2024-03-21T06:21:00.5948424Z
2024-03-21T06:31:13.8519110Z + cd boost
```
It took about now
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012287196
> @PHILO-HE It seems that downloading thrift-0.16.0 often fails in CI.
Yes, it blocks building arrow. Let's dismiss the irrelevant failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Replace "git clone" by downloading tar package for boost in setup-ubuntu.sh [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012409524
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5071_time.csv</font></td>
<td><font color=#000000>log/native_master_03_20_2024_e1f0c01a7_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>34.86</font></td>
<td><font color=#F92663>38.53</font></td>
<td><font color=#F92663>3.667</font></td>
<td><font color=#F92663>110.52%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>23.72</font></td>
<td><font color=#F92663>24.00</font></td>
<td><font color=#F92663>0.278</font></td>
<td><font color=#F92663>101.17%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>36.78</font></td>
<td><font color=#F92663>37.50</font></td>
<td><font color=#F92663>0.715</font></td>
<td><font color=#F92663>101.94%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>38.36</font></td>
<td><font color=#F92663>38.61</font></td>
<td><font color=#F92663>0.249</font></td>
<td><font color=#F92663>100.65%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>69.58</font></td>
<td><font color=#F92663>71.63</font></td>
<td><font color=#F92663>2.055</font></td>
<td><font color=#F92663>102.95%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>5.67</font></td>
<td><font color=#F92663>7.37</font></td>
<td><font color=#F92663>1.692</font></td>
<td><font color=#F92663>129.83%</font></td>
</tr>
<tr>
<td><font color=#F92663>q7</font></td>
<td><font color=#F92663>82.50</font></td>
<td><font color=#F92663>83.96</font></td>
<td><font color=#F92663>1.462</font></td>
<td><font color=#F92663>101.77%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>86.87</font></td>
<td><font color=#6F9915>84.46</font></td>
<td><font color=#6F9915>-2.416</font></td>
<td><font color=#6F9915>97.22%</font></td>
</tr>
<tr>
<td><font color=#F92663>q9</font></td>
<td><font color=#F92663>121.47</font></td>
<td><font color=#F92663>125.15</font></td>
<td><font color=#F92663>3.674</font></td>
<td><font color=#F92663>103.02%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>45.77</font></td>
<td><font color=#6F9915>45.58</font></td>
<td><font color=#6F9915>-0.196</font></td>
<td><font color=#6F9915>99.57%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q11</font></td>
<td><font color=#6F9915>21.14</font></td>
<td><font color=#6F9915>20.52</font></td>
<td><font color=#6F9915>-0.624</font></td>
<td><font color=#6F9915>97.05%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>23.17</font></td>
<td><font color=#F92663>28.80</font></td>
<td><font color=#F92663>5.633</font></td>
<td><font color=#F92663>124.31%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>46.92</font></td>
<td><font color=#F92663>48.70</font></td>
<td><font color=#F92663>1.780</font></td>
<td><font color=#F92663>103.79%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14</font></td>
<td><font color=#F92663>18.50</font></td>
<td><font color=#F92663>22.25</font></td>
<td><font color=#F92663>3.745</font></td>
<td><font color=#F92663>120.24%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>29.57</font></td>
<td><font color=#F92663>31.14</font></td>
<td><font color=#F92663>1.576</font></td>
<td><font color=#F92663>105.33%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q16</font></td>
<td><font color=#6F9915>15.85</font></td>
<td><font color=#6F9915>15.42</font></td>
<td><font color=#6F9915>-0.433</font></td>
<td><font color=#6F9915>97.27%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>101.93</font></td>
<td><font color=#F92663>102.47</font></td>
<td><font color=#F92663>0.542</font></td>
<td><font color=#F92663>100.53%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>141.28</font></td>
<td><font color=#F92663>143.60</font></td>
<td><font color=#F92663>2.314</font></td>
<td><font color=#F92663>101.64%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.63</font></td>
<td><font color=#F92663>13.64</font></td>
<td><font color=#F92663>0.015</font></td>
<td><font color=#F92663>100.11%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>27.74</font></td>
<td><font color=#6F9915>27.02</font></td>
<td><font color=#6F9915>-0.721</font></td>
<td><font color=#6F9915>97.40%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>227.11</font></td>
<td><font color=#6F9915>225.52</font></td>
<td><font color=#6F9915>-1.595</font></td>
<td><font color=#6F9915>99.30%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>14.20</font></td>
<td><font color=#6F9915>13.96</font></td>
<td><font color=#6F9915>-0.245</font></td>
<td><font color=#6F9915>98.27%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1226.64</font></td>
<td><font color=#F92663>1249.81</font></td>
<td><font color=#F92663>23.165</font></td>
<td><font color=#F92663>101.89%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012110675
Hi @liujiayi771, thanks for your work! Seems these changes can be accepted by upstream velox? If so, maybe you can also propose a pr there. Anyway, I think it's OK to firstly merge this pr to accelerate Gluten CI as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #5071:
URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012208343
@PHILO-HE It seems that downloading thrift-0.16.0 often fails in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org