[GitHub] [accumulo] cshannon commented on a diff in pull request #3384: fix 3372 - use waitFor to handle async conditions

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #3384:
URL: https://github.com/apache/accumulo/pull/3384#discussion_r1186710068


##########
test/src/main/java/org/apache/accumulo/test/functional/MemoryStarvedScanIT.java:
##########
@@ -307,13 +308,16 @@ public void testBatchScanReturnsEarlyDueToLowMemory() throws Exception {
         consumeServerMemory(scanner);
 
         // Wait for longer than the memory check interval
-        Thread.sleep(6000);
+        Thread.sleep(3000);

Review Comment:
   Why do you still have a sleep here? The main point of using the Wait.waitFor() api is you don't need to include anymore artificial sleeps as it will progress when ready.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org