You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/06/24 18:56:37 UTC
[GitHub] zeppelin pull request #1085: [MINOR]Removed some codes using interpreterClas...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1085
[MINOR]Removed some codes using interpreterClassList
### What is this PR for?
Removing dependency from interpreterClassList because this prevent new interpreter without interpreterClassList from registering in Zeppelin.
### What type of PR is it?
[Bug Fix | Refactoring]
### Todos
* [ ] - Removed codes
### What is the Jira issue?
N/A
### How should this be tested?
It doesn't have any change on user level.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin minor-remove-usage-of-interpreterclasslist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1085
----
commit 0caa63943423c289eef1f8dcae813bafcbf1c737
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-24T18:52:24Z
Revmoed some codes using interpreterClassList
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1085: [MINOR]Removed some codes using interpreterClassList
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1085
Iterating interpreterClassList is mainly for keeping order of interpreters defined in `zeppelin.interpreters` property.
Therefore this PR will not only refactoring the code but also bring some user level behavior changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1085: [MINOR]Removed some codes using interpreterClassList
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1085
@Leemoonsoo My last commit solves ordering interpreters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1085: [MINOR]Removed some codes using interpreterClas...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/1085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1085: [MINOR]Removed some codes using interpreterClassList
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1085
@jongyoul Yes, i thought so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1085: [MINOR]Removed some codes using interpreterClassList
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1085
@Leemoonsoo Could you please describe in details? Do you mean the order of interpreter tab?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1085: [MINOR]Removed some codes using interpreterClassList
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1085
@Leemoonsoo I've figured out what you said. This PR changes the way to find a default interpreter, isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---