You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by jw...@apache.org on 2012/10/04 18:37:44 UTC
svn commit: r1394148 - in /myfaces/trinidad/trunk:
trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/javax/faces/Component.xml
Author: jwaldman
Date: Thu Oct 4 16:37:44 2012
New Revision: 1394148
URL: http://svn.apache.org/viewvc?rev=1394148&view=rev
Log:
TRINIDAD-2313 Improvement in the component id description to align with the JSF Spec documentation
Thanks to Ji Kim for the patch
Modified:
myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
myfaces/trinidad/trunk/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/javax/faces/Component.xml
Modified: myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java?rev=1394148&r1=1394147&r2=1394148&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java (original)
+++ myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java Thu Oct 4 16:37:44 2012
@@ -618,12 +618,15 @@ abstract public class UIXComponentBase e
}
/**
- * Sets the identifier for the component. The identifier
- * must follow a subset of the syntax allowed in HTML:
+ * Sets the identifier for the component.
+ * the identifier for the component. Every component may be named by a component identifier that must conform to the following rules:
* <ul>
- * <li>Must not be a zero-length String.</li>
- * <li>First character must be an ASCII letter (A-Za-z) or an underscore ('_').</li>
- * <li>Subsequent characters must be an ASCII letter or digit (A-Za-z0-9), an underscore ('_'), or a dash ('-').
+ * <li>They must start with a letter (as defined by the Character.isLetter() method) or underscore ( _ ).</li>
+ * <li>Subsequent characters must be letters (as defined by the Character.isLetter() method), digits as defined by the Character.isDigit() method,
+ * dashes ( - ), or underscores ( _ ). To minimize the size of responses generated by JavaServer Faces, it is recommended that component identifiers
+ * be as short as possible. If a component has been given an identifier, it must be unique in the namespace of the closest ancestor to that component
+ * that is a NamingContainer (if any).
+ * </li>
* </ul>
*/
@Override
Modified: myfaces/trinidad/trunk/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/javax/faces/Component.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/javax/faces/Component.xml?rev=1394148&r1=1394147&r2=1394148&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/javax/faces/Component.xml (original)
+++ myfaces/trinidad/trunk/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/javax/faces/Component.xml Thu Oct 4 16:37:44 2012
@@ -26,12 +26,13 @@
<component-type>javax.faces.Component</component-type>
<component-class>javax.faces.component.UIComponent</component-class>
<property>
- <description><![CDATA[<html>the identifier for the component. The identifier
-must follow a subset of the syntax allowed in HTML:
+ <description><![CDATA[<html>the identifier for the component. Every component may be named by a component identifier that must conform to the following rules:
<ul>
-<li>Must not be a zero-length String.</li>
-<li>First character must be an ASCII letter (A-Za-z) or an underscore ('_').</li>
-<li>Subsequent characters must be an ASCII letter or digit (A-Za-z0-9), an underscore ('_'), or a dash ('-').</li>
+<li>They must start with a letter (as defined by the Character.isLetter() method) or underscore ( _ ).</li>
+<li>Subsequent characters must be letters (as defined by the Character.isLetter() method), digits as defined by the Character.isDigit() method,
+dashes ( - ), or underscores ( _ ). To minimize the size of responses generated by JavaServer Faces, it is recommended that component identifiers
+be as short as possible. If a component has been given an identifier, it must be unique in the namespace of the closest ancestor to that component
+that is a NamingContainer (if any).</li>
</ul></html>]]>
</description>
<property-name>id</property-name>