You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lvyanquan (via GitHub)" <gi...@apache.org> on 2024/10/15 08:46:23 UTC
[PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
lvyanquan opened a new pull request, #3644:
URL: https://github.com/apache/flink-cdc/pull/3644
1) bump version to 0.9.0.
2) Forcibly add cache-enabled = false in catalog option to avoid using previous table schema.
Refer to https://paimon.apache.org/docs/master/maintenance/configurations/#catalogoptions, after bump version to 0.9.0, we can support create table with uppercase columns using allow-upper-case catalog option, which resolved https://issues.apache.org/jira/browse/FLINK-36475.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#issuecomment-2413273374
@beryllw @melin CC as you may interested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on code in PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#discussion_r1814860259
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonCommitter.java:
##########
@@ -44,8 +48,34 @@ public PaimonCommitter(Options catalogOptions, String commitUser) {
storeMultiCommitter =
new StoreMultiCommitter(
() -> FlinkCatalogFactory.createPaimonCatalog(catalogOptions),
- commitUser,
- null);
+ new org.apache.paimon.flink.sink.Committer.Context() {
Review Comment:
Thanks for your advice, addressed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#issuecomment-2573013465
@leonardBang @ruanhang1993 PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "MOBIN-F (via GitHub)" <gi...@apache.org>.
MOBIN-F commented on PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#issuecomment-2503047338
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "MOBIN-F (via GitHub)" <gi...@apache.org>.
MOBIN-F commented on code in PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#discussion_r1800889167
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonCommitter.java:
##########
@@ -44,8 +48,34 @@ public PaimonCommitter(Options catalogOptions, String commitUser) {
storeMultiCommitter =
new StoreMultiCommitter(
() -> FlinkCatalogFactory.createPaimonCatalog(catalogOptions),
- commitUser,
- null);
+ new org.apache.paimon.flink.sink.Committer.Context() {
Review Comment:
Maybe we can use org.apache.paimon.flink.sink.Committer.createContext(
commitUser, null, true, false, null));?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "beryllw (via GitHub)" <gi...@apache.org>.
beryllw commented on PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#issuecomment-2425634096
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#issuecomment-2579346720
> I've noticed a reproducible failure in `PaimonSinkITCase#testSinkWithDataChange` test case with deleteVector enabled (See [#1](https://github.com/yuxiqian/flink-cdc/actions/runs/12683416363/job/35350457627), [#2](https://github.com/apache/flink-cdc/actions/runs/12684681355/job/35353768996)). Running it locally will fail 10 out of 10 attempts.
Thanks for pointing out this, plan to fix in https://github.com/apache/flink-cdc/pull/3846.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644#issuecomment-2579295848
I've noticed a reproducible failure in `PaimonSinkITCase#testSinkWithDataChange` test case with deleteVector enabled (See [#1](https://github.com/yuxiqian/flink-cdc/actions/runs/12683416363/job/35350457627), [#2](https://github.com/apache/flink-cdc/actions/runs/12684681355/job/35353768996)). Running it locally will fail 10 out of 10 attempts.
Any thoughts from @lvyanquan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36524][pipeline-connector][paimon] bump version of Paimon to 0.9.0 [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang merged PR #3644:
URL: https://github.com/apache/flink-cdc/pull/3644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org