You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rambleraptor (via GitHub)" <gi...@apache.org> on 2026/03/30 20:52:01 UTC
[PR] Multiple bug fixes [iceberg-terraform]
rambleraptor opened a new pull request, #29:
URL: https://github.com/apache/iceberg-terraform/pull/29
I found a few bug fixes in testing. Here's the list:
- Provider URI may be null during plan-time if you're using Terraform to stand up your catalog (this will occur if you're standing up your Glue/BigQuery catalog in the same script)
- Namespace / table names should act as primary keys
- Partition Fields were sometimes getting Terraform value conversion errors.
- Treating optional IDs as proper types in conversion
I've added some tests for these as well. I can break this up into multiple PRs, since this is a bit of a random assortment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Multiple bug fixes [iceberg-terraform]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #29:
URL: https://github.com/apache/iceberg-terraform/pull/29#discussion_r3018128015
##########
internal/provider/table_schema.go:
##########
@@ -392,16 +427,17 @@ func (s *icebergTableSchemaFieldStructProperties) UnmarshalJSON(b []byte) error
func marshalFieldJSON(id types.Int64, name, typeStr string, required bool, doc *string, listProps, mapProps, structProps interface{}) ([]byte, error) {
type Field struct {
- ID int64 `json:"id"`
+ ID *int64 `json:"id,omitempty"`
Review Comment:
isn't the ID required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Multiple bug fixes [iceberg-terraform]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #29:
URL: https://github.com/apache/iceberg-terraform/pull/29#discussion_r3018893326
##########
internal/provider/table_schema.go:
##########
@@ -392,16 +427,17 @@ func (s *icebergTableSchemaFieldStructProperties) UnmarshalJSON(b []byte) error
func marshalFieldJSON(id types.Int64, name, typeStr string, required bool, doc *string, listProps, mapProps, structProps interface{}) ([]byte, error) {
type Field struct {
- ID int64 `json:"id"`
+ ID *int64 `json:"id,omitempty"`
Review Comment:
We're not being consistent about how we're treating IDs.
Some IDs should be managed by Terraform (not user-settable, Terraform will store these values + increment them on updates). Some should be managed by users.
Let's just standardize this. Here's what I'm thinking.
- `schema-id` - Terraform managed.
- `field-id` - User managed. This isn't ideal, but the ID is the primary key of a field. If you try to rename a field (without specifying the ID), Terraform will become very confused.
- `partition-specs.spec-id` - Terraform managed.
- `sort_orders.order-id` - Terraform managed.
- `partition-specs.source-id`. User managed. These are references to a field.
- `partition-specs.field-id`. User managed. These are references to a field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Multiple bug fixes [iceberg-terraform]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor closed pull request #29: Multiple bug fixes
URL: https://github.com/apache/iceberg-terraform/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org