You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/23 14:49:00 UTC
[jira] [Work logged] (BEAM-3607) Move checkNotNull arg checks to a new checkArgumentNotNull
[ https://issues.apache.org/jira/browse/BEAM-3607?focusedWorklogId=746632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746632 ]
ASF GitHub Bot logged work on BEAM-3607:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/22 14:48
Start Date: 23/Mar/22 14:48
Worklog Time Spent: 10m
Work Description: NomNomGit opened a new pull request #17165:
URL: https://github.com/apache/beam/pull/17165
I think doing this for the whole project would be a bit much in one PR. I would create additonal PRs, if this one is okay.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 746632)
Remaining Estimate: 0h
Time Spent: 10m
> Move checkNotNull arg checks to a new checkArgumentNotNull
> ----------------------------------------------------------
>
> Key: BEAM-3607
> URL: https://issues.apache.org/jira/browse/BEAM-3607
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: P3
> Labels: Clarified, beginner, newbie, starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The simple fact is that {{checkNotNull}} throws NPE which to users looks like a core dump sort of failure. It throws a "500 error" when we usually intend a "400 error", so to speak, so the bugs get filed on the wrong components, or users don't know they passed the wrong thing, etc.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)