[GitHub] [spark] tgravescs commented on a change in pull request #26586: [SPARK-29950][k8s] Blacklist deleted executors in K8S with dynamic allocation.

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #26586: [SPARK-29950][k8s] Blacklist deleted executors in K8S with dynamic allocation.
URL: https://github.com/apache/spark/pull/26586#discussion_r355740014
 
 

 ##########
 File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
 ##########
 @@ -72,6 +72,11 @@ private[spark] class ExecutorPodsAllocator(
 
   private var lastSnapshot = ExecutorPodsSnapshot(Nil)
 
+  // Executors that have been deleted by this allocator but not yet detected as deleted in
+  // a snapshot from the API server. This is used to deny registration from these executors
+  // if they happen to come up before the deletion takes effect.
+  @volatile private var excessExecutors = Set.empty[Long]
 
 Review comment:
   nit: perhaps deletedExecutorIds

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org