You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2018/04/05 07:53:43 UTC
[GitHub] flink pull request #5820: [hotfix] removed unused scala imports
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5820
[hotfix] removed unused scala imports
## What is the purpose of the change
removed unused scala imports
## Brief change log
removed unused scala imports
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
none
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink hotfix_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5820
----
commit f6940a0bf0fd5ff487a63ffad29e4dc9cd7a970c
Author: Bowen Li <bo...@...>
Date: 2018-04-05T07:52:37Z
[hotfix] removed unused scala imports
----
---
[GitHub] flink issue #5820: [hotfix] [DataStream API] [Scala] removed unused scala im...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5820
I wouldn't bother cleaning up unused imports until we have a checkstyle rule in place to enforce it.
---
[GitHub] flink pull request #5820: [hotfix] [DataStream API] [Scala] removed unused s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5820
---
[GitHub] flink issue #5820: [hotfix] [DataStream API] [Scala] removed unused scala im...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5820
This looks good to me 👍. Will merge.
---
[GitHub] flink issue #5820: [hotfix] [DataStream API] [Scala] removed unused scala im...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5820
@zentol which scala checkstyle mvn plugin are you looking at? I didn't find any available ones, and I'm afraid there might will not be one.
scalastyle explicitly said that they will not support capturing unused imports at https://github.com/scalastyle/scalastyle/issues/193
---