You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Brian LeRoux <b...@brian.io> on 2013/12/11 05:04:27 UTC
review request for cordova-js gruntfile refactor
https://github.com/apache/cordova-js/pull/61
In my quest to add the browser platform I got a little sidetracked cleaning
up the gruntfile. Please have a look. The _btest fails currently but I
think I want to move to phantom anyhow. Otherwise everything is identical.
Re: review request for cordova-js gruntfile refactor
Posted by Brian LeRoux <b...@brian.io>.
Cool that is literally all those 8 commits do. (Rename, separate out into
discreet modules.)
I'll merge.
On Dec 12, 2013 2:04 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
> Brian - the 8 commits change is pretty overwhelming to look at all at once.
> Could you split them up into those that you want looked at, and those that
> you don't (e.g. lib->src & splitting gruntfile into separate files don't
> really need to be looked at).
>
>
> On Tue, Dec 10, 2013 at 11:04 PM, Brian LeRoux <b...@brian.io> wrote:
>
> > https://github.com/apache/cordova-js/pull/61
> >
> > In my quest to add the browser platform I got a little sidetracked
> cleaning
> > up the gruntfile. Please have a look. The _btest fails currently but I
> > think I want to move to phantom anyhow. Otherwise everything is
> identical.
> >
>
Re: review request for cordova-js gruntfile refactor
Posted by Andrew Grieve <ag...@chromium.org>.
Brian - the 8 commits change is pretty overwhelming to look at all at once.
Could you split them up into those that you want looked at, and those that
you don't (e.g. lib->src & splitting gruntfile into separate files don't
really need to be looked at).
On Tue, Dec 10, 2013 at 11:04 PM, Brian LeRoux <b...@brian.io> wrote:
> https://github.com/apache/cordova-js/pull/61
>
> In my quest to add the browser platform I got a little sidetracked cleaning
> up the gruntfile. Please have a look. The _btest fails currently but I
> think I want to move to phantom anyhow. Otherwise everything is identical.
>