You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/03 18:09:25 UTC

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #677: Close the old connection to make sure the broker drops the producer on its side

cckellogg commented on a change in pull request #677:
URL: https://github.com/apache/pulsar-client-go/pull/677#discussion_r762145505



##########
File path: pulsar/internal/connection.go
##########
@@ -858,13 +858,14 @@ func (c *connection) Close() {
 		c.Lock()
 		cnx := c.cnx
 		c.Unlock()
-		c.changeState(connectionClosed)
+		c.changeState(connectionClosing)

Review comment:
       How does changing the state here to `connectionClosing` and then changing it to `connectionClosed` later fix the issue?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org