You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2015/01/13 23:34:23 UTC

Re: Review Request 24704: Patch for KAFKA-1499

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24704/#review67954
-----------------------------------------------------------

Ship it!


- Joel Koshy


On Dec. 26, 2014, 4:09 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24704/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 4:09 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1499
>     https://issues.apache.org/jira/browse/KAFKA-1499
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Support given for Broker-side compression, Addersing Joel's comments
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/Log.scala 024506cd00556a0037c0b3b6b603da32968b69ab 
>   core/src/main/scala/kafka/log/LogConfig.scala ca7a99e99f641b2694848b88bf4ae94657071d03 
>   core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 788c7864bc881b935975ab4a4e877b690e65f1f1 
>   core/src/main/scala/kafka/message/CompressionCodec.scala 9439d2bc29a0c2327085f08577c6ce1b01db1489 
>   core/src/main/scala/kafka/server/KafkaConfig.scala 6e26c5436feb4629d17f199011f3ebb674aa767f 
>   core/src/main/scala/kafka/server/KafkaServer.scala 1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe 
>   core/src/test/scala/kafka/log/LogConfigTest.scala 99b0df7b69c5e0a1b6251c54592c6ef63b1800fe 
>   core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala PRE-CREATION 
>   core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala 4e45d965bc423192ac704883ee75e9727006f89b 
>   core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala 2377abe4933e065d037828a214c3a87e1773a8ef 
> 
> Diff: https://reviews.apache.org/r/24704/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>