[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4226: Support to read/write parquet for FixedSizeList type

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4226:
URL: https://github.com/apache/arrow-rs/pull/4226#discussion_r1195040927


##########
parquet/src/arrow/array_reader/list_array.rs:
##########
@@ -227,8 +228,13 @@ impl<OffsetSize: OffsetSizeTrait> ArrayReader for ListArrayReader<OffsetSize> {
 
         let list_data = unsafe { data_builder.build_unchecked() };
 
-        let result_array = GenericListArray::<OffsetSize>::from(list_data);
-        Ok(Arc::new(result_array))
+        let result_array: ArrayRef = match *list_data.data_type() {
+            ArrowType::FixedSizeList(_, _) => {
+                Arc::new(FixedSizeListArray::from(list_data))

Review Comment:
   This is not correct, you are constructing a FixedSizeListArray from an ArrayData that contains an offsets buffer. In particular this code needs to verify that the values array is the right length. I'll see if I can't finish up #3879 so that you can make use of that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org