You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/02/16 06:34:27 UTC
Review Request 65683: Added discard handling to Docker library
functions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Repository: mesos
Description
-------
Added discard handling to Docker library functions.
Diffs
-----
src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
Diff: https://reviews.apache.org/r/65683/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197662
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65683]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 16, 2018, 6:34 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2018, 6:34 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discard handling to Docker library functions.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65683/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197667
-----------------------------------------------------------
PASS: Mesos patch 65683 was successfully built and tested.
Reviews applied: `['65683']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65683
- Mesos Reviewbot Windows
On Feb. 16, 2018, 6:34 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2018, 6:34 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discard handling to Docker library functions.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65683/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197709
-----------------------------------------------------------
PASS: Mesos patch 65683 was successfully built and tested.
Reviews applied: `['65683']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65683
- Mesos Reviewbot Windows
On Feb. 17, 2018, 2:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2018, 2:37 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discard handling to Docker library functions.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65683/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197713
-----------------------------------------------------------
PASS: Mesos patch 65683 was successfully built and tested.
Reviews applied: `['65683']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65683
- Mesos Reviewbot Windows
On Feb. 17, 2018, 2:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2018, 2:37 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discard handling to Docker library functions.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65683/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197715
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65683]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 17, 2018, 2:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2018, 2:37 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discard handling to Docker library functions.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65683/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65683: Updated discard handling in Docker library
functions.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/
-----------------------------------------------------------
(Updated Feb. 22, 2018, 12:30 a.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Summary (updated)
-----------------
Updated discard handling in Docker library functions.
Bugs: MESOS-8575
https://issues.apache.org/jira/browse/MESOS-8575
Repository: mesos
Description (updated)
-------
Updated discard handling in Docker library functions.
Diffs (updated)
-----
src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
Diff: https://reviews.apache.org/r/65683/diff/3/
Changes: https://reviews.apache.org/r/65683/diff/2-3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/
-----------------------------------------------------------
(Updated Feb. 17, 2018, 2:37 a.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-8575
https://issues.apache.org/jira/browse/MESOS-8575
Repository: mesos
Description
-------
Added discard handling to Docker library functions.
Diffs
-----
src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
Diff: https://reviews.apache.org/r/65683/diff/2/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/
-----------------------------------------------------------
(Updated Feb. 17, 2018, 2:36 a.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Repository: mesos
Description
-------
Added discard handling to Docker library functions.
Diffs (updated)
-----
src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
Diff: https://reviews.apache.org/r/65683/diff/2/
Changes: https://reviews.apache.org/r/65683/diff/1-2/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 65683: Added discard handling to Docker library
functions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197661
-----------------------------------------------------------
PASS: Mesos patch 65683 was successfully built and tested.
Reviews applied: `['65683']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65683
- Mesos Reviewbot Windows
On Feb. 16, 2018, 6:34 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2018, 6:34 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discard handling to Docker library functions.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65683/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>