You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/11/21 13:17:03 UTC
svn commit: r1815920 - in
/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend:
BackendListenerClient.java BackendListenerContext.java
BackendListenerGui.java UserMetric.java
Author: pmouawad
Date: Tue Nov 21 13:17:02 2017
New Revision: 1815920
URL: http://svn.apache.org/viewvc?rev=1815920&view=rev
Log:
Fix SONAR warnings
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerContext.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/UserMetric.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java?rev=1815920&r1=1815919&r2=1815920&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java Tue Nov 21 13:17:02 2017
@@ -73,7 +73,7 @@ public interface BackendListenerClient {
* Context is readonly
* @throws Exception when setup fails
*/
- void setupTest(BackendListenerContext context) throws Exception;
+ void setupTest(BackendListenerContext context) throws Exception; // NOSONAR
/**
* Handle sampleResults, this can be done in many ways:
@@ -98,7 +98,7 @@ public interface BackendListenerClient {
* initialization parameters.
* @throws Exception when tear down fails
*/
- void teardownTest(BackendListenerContext context) throws Exception;
+ void teardownTest(BackendListenerContext context) throws Exception; // NOSONAR
/**
* Provide a list of parameters which this test supports. Any parameter
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerContext.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerContext.java?rev=1815920&r1=1815919&r2=1815920&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerContext.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerContext.java Tue Nov 21 13:17:02 2017
@@ -123,12 +123,14 @@ public class BackendListenerContext {
* the name of the parameter whose value should be retrieved
* @return the value of the parameter
*
+ * @throws IllegalArgumentException
+ * if no value defined
* @throws NumberFormatException
* if the parameter is not specified or is not an integer
*
* @see java.lang.Integer#decode(java.lang.String)
*/
- public int getIntParameter(String name) throws NumberFormatException {
+ public int getIntParameter(String name) {
if (params == null || !params.containsKey(name)) {
throw new IllegalArgumentException("No value for parameter named '" + name + "'.");
}
@@ -183,9 +185,9 @@ public class BackendListenerContext {
*
* @see Long#decode(String)
*/
- public long getLongParameter(String name) throws NumberFormatException {
+ public long getLongParameter(String name) {
if (params == null || !params.containsKey(name)) {
- throw new NumberFormatException("No value for parameter named '" + name + "'.");
+ throw new IllegalArgumentException("No value for parameter named '" + name + "'.");
}
return Long.parseLong(params.get(name));
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java?rev=1815920&r1=1815919&r2=1815920&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java Tue Nov 21 13:17:02 2017
@@ -214,9 +214,7 @@ public class BackendListenerGui extends
newArgs.addArgument(name, value);
}
}
- userArgMap.forEach((k,v) -> {
- newArgs.addArgument(k, v);
- });
+ userArgMap.forEach((k,v) -> newArgs.addArgument(k, v));
className = newClassName;
argsPanel.configure(newArgs);
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/UserMetric.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/UserMetric.java?rev=1815920&r1=1815919&r2=1815920&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/UserMetric.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/UserMetric.java Tue Nov 21 13:17:02 2017
@@ -36,11 +36,12 @@ public class UserMetric {
*
*/
public UserMetric() {
+ super();
}
/**
* Add a {@link SampleResult} to be used in the statistics
- * @param result {@link SampleResult} to be used
+ * @param result {@link SampleResult} not used
*/
public synchronized void add(SampleResult result) {
usersStats.addValue(JMeterContextService.getThreadCounts().activeThreads);