[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.

["Ismael Juma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961033#comment-15961033 ] 

Ismael Juma commented on KAFKA-4401:
------------------------------------

Note that we changed both classes to be abstract classes as well as ZooKeeperTestHarness so that we could place the IntegrationTest annotation (i.e. @Category(Array(classOf[IntegrationTest]))`) in the base class. With traits, this would not work. Additionally, I filed KAFKA-5041 for creating a supported library for writing tests involving a Kafka cluster. Given that, I suggest closing this one. What do you think [~becket_qin]?

> Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
> ------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-4401
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4401
>             Project: Kafka
>          Issue Type: Task
>          Components: unit tests
>    Affects Versions: 0.10.1.0
>            Reporter: Jiangjie Qin
>            Assignee: Jiangjie Qin
>
> The IntegartionTestHarness and KafkaServerTestHarness are useful not only in Kafka unit test, but also useful for the unit tests in other products that depend on Kafka.
> Currently there are two issues making those two test harness classes hard to use by other Java users.
> 1. The two classes are Scala traits. This makes it difficult for people to write Java unit test code. 
> 2. Some of the interfaces are Scala only. 
> It will be good to expose those two classes for more general usage and make them Java friendly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)