You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/09/12 17:26:41 UTC
[GitHub] [hop] shlxue opened a new pull request, #1679: HOP-3974: Disable preview feature when hop-server don't support graphic environment
shlxue opened a new pull request, #1679:
URL: https://github.com/apache/hop/pull/1679
SVG and Font both dependency graphic environment.
On macOS, like jvm option: -XstartOnFirstThread, we should load graphic environment at main thread.
GUI environment usually works fine on the default jdk unless the java.desktop module is removed or custom module list.
Hop-Server as rest api service, maybe the preview feature is better as an optional feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1679: HOP-3974: Disable preview feature when hop-server don't support graphic environment
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1679:
URL: https://github.com/apache/hop/pull/1679#issuecomment-1244552487
Other JDK/OS combinations: My guess is that they are still mostly GUI environment related（swt, not java.awt）, but they may be more complicated to solve. This happens to be related to another new requirement of mine, which I'll say more about later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1679: HOP-3974: Disable preview feature when hop-server don't support graphic environment
Posted by GitBox <gi...@apache.org>.
hansva merged PR #1679:
URL: https://github.com/apache/hop/pull/1679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1679: HOP-3974: Disable preview feature when hop-server don't support graphic environment
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1679:
URL: https://github.com/apache/hop/pull/1679#issuecomment-1244519611
Yes, this is only for the MacOS platform. I have noticed problems with other JDK/OS combinations mentioned on JIRA. I think the PR only completed 10% of the progress of HOP-3974.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1679: HOP-3974: Disable preview feature when hop-server don't support graphic environment
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1679:
URL: https://github.com/apache/hop/pull/1679#issuecomment-1244220506
it's a bit strange that it does work when using our docker container. but it doesn't on some OS/JDK combinations.
Great fix though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org