You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2016/11/02 20:51:21 UTC
[GitHub] storm pull request #1759: STORM-2185: Storm Supervisor doesn't delete direct...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1759
STORM-2185: Storm Supervisor doesn't delete directories properly sometimes - 1.x branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2185-1.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1759
----
commit 0035a2cc91095dc440f0ca44df3a61d85db9494c
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-10-31T21:05:44Z
Fixing KafkaSpout acking.
commit b4dc3410c3dca405560de8b5a2649aecb4c2934d
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-10-31T21:11:18Z
Fixing spacing.
commit 5d6b6e4ee6ac55f7905082d01343740ca43594ce
Author: Kyle Nusbaum <kn...@yahoo-inc.com>
Date: 2016-11-02T20:29:53Z
Fix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1759: STORM-2185: Storm Supervisor doesn't delete directories p...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1759
@knusbaum if this is merged in could you please close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1759: STORM-2185: Storm Supervisor doesn't delete directories p...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1759
@knusbaum I merged 1.x and 1.0.x branch. Could you close this PR? Auto-closing PR doesn't work with PR which is not against master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1759: STORM-2185: Storm Supervisor doesn't delete directories p...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1759
@knusbaum No I manually did it. I have been creating branch even cherry-picking for backporting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1759: STORM-2185: Storm Supervisor doesn't delete directories p...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1759
As a note to whoever merges this in we should merge this to 1.0.x too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1759: STORM-2185: Storm Supervisor doesn't delete directories p...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1759
@HeartSaVioR Are you using harshach's script to merge these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1759: STORM-2185: Storm Supervisor doesn't delete direct...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1759
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1759: STORM-2185: Storm Supervisor doesn't delete directories p...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1759
+1 Commit message should be modified but can be handled while merging. (Same as PR for master)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---