You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Peter Donald <do...@apache.org> on 2001/05/09 01:11:21 UTC

Re: cvs commit: jakarta-avalon-logkit/lib avalon-framework.jar

At 09:07  8/5/01 -0000, bloritsch@apache.org wrote:
>bloritsch    01/05/08 14:07:37
>
>  Added:       lib      avalon-framework.jar
>  Log:
>  Add ability to print cascading exceptions.  This implementation does not
require
>  Avalon Framework in the distributed jar--just the compile.  It tests the
exception to
>  see if it is an instance of CascadingThrowable.  If not, everything acts
as it has in
>  the past.  If so, then we recursively call the method until there are no
more
>  CascadingThrowable.

-1 on this change as Avalon *will* be required at runtime. The reason is
that PatternFormatter will not resolve without AvalonFramework present and
as almost all users of Logkit use PatternFormatter (as it is default
formatter).


Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-avalon-logkit/lib avalon-framework.jar

Posted by Harmeet Bedi <hb...@yahoo.com>.
[Peter Donald]
> 2. make default display of time be (new Date(time)).toString() rather than
> just time
>
> Anyone have any opnions on these. (I see no problem with either). Both
have

Date <toString> could be slow and the date generated string is lengthy: "EEE
MMM dd HH:mm:ss zzz yyyy"

I think a faster, and shorter date format would be nicer.

Harmeet

----- Original Message -----
From: "Peter Donald" <do...@apache.org>
To: "Avalon Development" <av...@jakarta.apache.org>
Cc: "Avalon Development" <av...@jakarta.apache.org>
Sent: Wednesday, May 09, 2001 6:42 AM
Subject: Re: cvs commit: jakarta-avalon-logkit/lib avalon-framework.jar


> At 09:21  9/5/01 -0400, Berin Loritsch wrote:
> >I *know* there has to be some kind of black magic....
>
> ;)
>
> >OK.  Can we have the AvalonLogFormatter in LogKit.  If the jar exists,
> that class
> >gets compiled--otherwise the ability of LogKit is crippled.  I think that
> would help
> >the most people involved--without penalizing people who just use LogKit.
>
> No problem there. Two other "fixes" that have been requested by a few
> people; they are
>
> 1. make time in LogEvent wall time rather than time since JVM load
> 2. make default display of time be (new Date(time)).toString() rather than
> just time
>
> Anyone have any opnions on these. (I see no problem with either). Both
have
> been requested a few times but never implemented to keep backwards compat
> .. but as we already broke it .... ;)
> Cheers,
>
> Pete
>
> *-----------------------------------------------------*
> | "Faced with the choice between changing one's mind, |
> | and proving that there is no need to do so - almost |
> | everyone gets busy on the proof."                   |
> |              - John Kenneth Galbraith               |
> *-----------------------------------------------------*
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org


_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com


---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-avalon-logkit/lib avalon-framework.jar

Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> 
> At 09:21  9/5/01 -0400, Berin Loritsch wrote:
> No problem there. Two other "fixes" that have been requested by a few
> people; they are
> 
> 1. make time in LogEvent wall time rather than time since JVM load
> 2. make default display of time be (new Date(time)).toString() rather than
> just time
> 
> Anyone have any opnions on these. (I see no problem with either). Both have
> been requested a few times but never implemented to keep backwards compat
> .. but as we already broke it .... ;)

Well, I reverted that fix, and added an AvalonFormatter class that merely
cascades the exceptions if applicable.  It is only compiled in if the
Avalon-Framework jar is present.  (so we no longer have broken backwards
compatibility).

Concider it a bug fix ;P

---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-avalon-logkit/lib avalon-framework.jar

Posted by Peter Donald <do...@apache.org>.
At 09:21  9/5/01 -0400, Berin Loritsch wrote:
>I *know* there has to be some kind of black magic....

;)

>OK.  Can we have the AvalonLogFormatter in LogKit.  If the jar exists,
that class
>gets compiled--otherwise the ability of LogKit is crippled.  I think that
would help
>the most people involved--without penalizing people who just use LogKit.

No problem there. Two other "fixes" that have been requested by a few
people; they are

1. make time in LogEvent wall time rather than time since JVM load
2. make default display of time be (new Date(time)).toString() rather than
just time

Anyone have any opnions on these. (I see no problem with either). Both have
been requested a few times but never implemented to keep backwards compat
.. but as we already broke it .... ;)
Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-avalon-logkit/lib avalon-framework.jar

Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> 
> At 09:07  8/5/01 -0000, bloritsch@apache.org wrote:
> >bloritsch    01/05/08 14:07:37
> >
> >  Added:       lib      avalon-framework.jar
> >  Log:
> >  Add ability to print cascading exceptions.  This implementation does not
> require
> >  Avalon Framework in the distributed jar--just the compile.  It tests the
> exception to
> >  see if it is an instance of CascadingThrowable.  If not, everything acts
> as it has in
> >  the past.  If so, then we recursively call the method until there are no
> more
> >  CascadingThrowable.
> 
> -1 on this change as Avalon *will* be required at runtime. The reason is
> that PatternFormatter will not resolve without AvalonFramework present and
> as almost all users of Logkit use PatternFormatter (as it is default
> formatter).

Crap.

I *know* there has to be some kind of black magic....

OK.  Can we have the AvalonLogFormatter in LogKit.  If the jar exists, that class
gets compiled--otherwise the ability of LogKit is crippled.  I think that would help
the most people involved--without penalizing people who just use LogKit.

---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org