You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/03/19 01:31:16 UTC
Review Request: change recovery service interval and queuing delay for HCat
push dependency
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9999/
-----------------------------------------------------------
Review request for oozie.
Description
-------
OOZIE-1274
This addresses bug OOZIE-1274.
https://issues.apache.org/jira/browse/OOZIE-1274
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1458061
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1458061
Diff: https://reviews.apache.org/r/9999/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request: change recovery service interval and queuing delay for
HCat push dependency
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9999/#review18090
-----------------------------------------------------------
Ship it!
+1 after addressing a minor comment
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9999/#comment38190>
if recoveryService variable is not used, can you remove it?
- Virag Kothari
On March 19, 2013, 12:31 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9999/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 12:31 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> OOZIE-1274
>
>
> This addresses bug OOZIE-1274.
> https://issues.apache.org/jira/browse/OOZIE-1274
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1458061
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1458061
>
> Diff: https://reviews.apache.org/r/9999/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: change recovery service interval to make it consistent
with oozie-default.xml
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9999/
-----------------------------------------------------------
(Updated March 19, 2013, 10:41 p.m.)
Review request for oozie.
Changes
-------
removed the method. thx
Description
-------
OOZIE-1274
This addresses bug OOZIE-1274.
https://issues.apache.org/jira/browse/OOZIE-1274
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1458071
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1458071
Diff: https://reviews.apache.org/r/9999/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request: change recovery service interval to make it consistent
with oozie-default.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9999/#review18107
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java
<https://reviews.apache.org/r/9999/#comment38226>
You can remove this method and get value directly in init. Not used anymore.
- Rohini Palaniswamy
On March 19, 2013, 10:06 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9999/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 10:06 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> OOZIE-1274
>
>
> This addresses bug OOZIE-1274.
> https://issues.apache.org/jira/browse/OOZIE-1274
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1458071
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1458071
>
> Diff: https://reviews.apache.org/r/9999/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: change recovery service interval to make it consistent
with oozie-default.xml
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9999/
-----------------------------------------------------------
(Updated March 19, 2013, 10:06 p.m.)
Review request for oozie.
Changes
-------
talked with Rohini
we decided to add static variables for default values in RecoveryService, which used in CoordPushDependencyCheckXCommand.java
Description
-------
OOZIE-1274
This addresses bug OOZIE-1274.
https://issues.apache.org/jira/browse/OOZIE-1274
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1458071
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1458071
Diff: https://reviews.apache.org/r/9999/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request: change recovery service interval to make it consistent
with oozie-default.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9999/#review18098
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9999/#comment38193>
Please get this from a method in RecoveryService instead of accessing the setting directly.
- Rohini Palaniswamy
On March 19, 2013, 5:38 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9999/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 5:38 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> OOZIE-1274
>
>
> This addresses bug OOZIE-1274.
> https://issues.apache.org/jira/browse/OOZIE-1274
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1458071
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1458071
>
> Diff: https://reviews.apache.org/r/9999/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: change recovery service interval to make it consistent
with oozie-default.xml
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9999/
-----------------------------------------------------------
(Updated March 19, 2013, 5:38 p.m.)
Review request for oozie.
Summary (updated)
-----------------
change recovery service interval to make it consistent with oozie-default.xml
Description
-------
OOZIE-1274
This addresses bug OOZIE-1274.
https://issues.apache.org/jira/browse/OOZIE-1274
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1458071
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1458071
Diff: https://reviews.apache.org/r/9999/diff/
Testing
-------
Thanks,
Ryota Egashira