You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Lars Hofhansl (Jira)" <ji...@apache.org> on 2020/08/26 19:29:00 UTC
[jira] [Updated] (PHOENIX-6107) Discuss BaseQueryIT
[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated PHOENIX-6107:
-----------------------------------
Description:
All 14 tests derived from BaseQueryIT are some of the slowest we have.
I noticed that all these tests run 7 times and each time create a table and 6 indexes.
So just in terms of setup there are 14*7 = 98 tables created and 14*7*6 = 588 indexes created.
It's not clear to me that that the runtime is justified, especially since we have so many other index ITs.
I think we can reduce this to run with one global index and one local index, for a repeat of only 3 times, instead of 7. That would benefit all derived test and shave of probably around 50% of the overall Phoenix test runtime.
I.e. 14*3 = 42 tables, and 14*3*2 = 84 indexes.
Yes, it would potentially reduce coverage. Hence a discussion.
Thoughts?
(Marked as "Wish" so that we can discuss)
was:
All tests derived from BaseQueryIT are some of the slowest we have.
I noticed that all these tests run 7 times and each time create a table and 6 indexes.
It's not clear to me that that the runtime is justified, especially since we have so many other index ITs.
I think we can reduce this to run with one global index and one local index, for a repeat of only 3 times, instead of 7. That would benefit all derived test and shave of probably around 50% of the overall Phoenix test runtime.
Thoughts?
(Marked as "Wish" so that we can discuss)
> Discuss BaseQueryIT
> -------------------
>
> Key: PHOENIX-6107
> URL: https://issues.apache.org/jira/browse/PHOENIX-6107
> Project: Phoenix
> Issue Type: Wish
> Reporter: Lars Hofhansl
> Priority: Major
>
> All 14 tests derived from BaseQueryIT are some of the slowest we have.
> I noticed that all these tests run 7 times and each time create a table and 6 indexes.
> So just in terms of setup there are 14*7 = 98 tables created and 14*7*6 = 588 indexes created.
> It's not clear to me that that the runtime is justified, especially since we have so many other index ITs.
> I think we can reduce this to run with one global index and one local index, for a repeat of only 3 times, instead of 7. That would benefit all derived test and shave of probably around 50% of the overall Phoenix test runtime.
> I.e. 14*3 = 42 tables, and 14*3*2 = 84 indexes.
> Yes, it would potentially reduce coverage. Hence a discussion.
> Thoughts?
> (Marked as "Wish" so that we can discuss)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)